From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] libnvdimm: allow legacy (e820) pmem region to clear bad blocks
Date: Fri, 9 Sep 2016 17:45:53 +0000 [thread overview]
Message-ID: <1473443112.18144.26.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4jtM0p6VhcS3f3UhE4YyVk9+TjTXBLXAUJ_meshm80C9w@mail.gmail.com>
On Thu, 2016-09-08 at 20:57 -0700, Dan Williams wrote:
> On Thu, Sep 8, 2016 at 5:28 PM, Verma, Vishal L
> <vishal.l.verma@intel.com> wrote:
> >
> > On Thu, 2016-09-08 at 16:33 -0700, Dave Jiang wrote:
> > >
> > > Bad blocks can be injected via /sys/block/pmemN/badblocks. In a
> > > situation
> > > where legacy pmem is being used or a pmem region created by using
> > > memmap
> > > kernel parameter, the injected bad blocks are not cleared due to
> > > nvdimm_clear_poison() failing from lack of ndctl function pointer.
> > > In
> > > this case we need to just return as handled and allow the bad
> > > blocks
> > > to
> > > be cleared rather than fail.
> > >
> > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > ---
> > > drivers/nvdimm/bus.c | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > Looks good to me!
> > Reveiewed-by: Vishal Verma <Vishal.l.verma@intel.com>
>
> Applied, although I just noticed that patchwork did not pick up that
> reviewed-by due to the typo.
Oops, that's what happens when I type stuff out instead of using vim
macros :)
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2016-09-09 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 23:33 [PATCH] libnvdimm: allow legacy (e820) pmem region to clear bad blocks Dave Jiang
2016-09-09 0:28 ` Verma, Vishal L
2016-09-09 3:57 ` Dan Williams
2016-09-09 17:45 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473443112.18144.26.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox