* [PATCH v3 33/38] virtio_pmem: convert to LE accessors [not found] <20200805134226.1106164-1-mst@redhat.com> @ 2020-08-05 13:44 ` Michael S. Tsirkin 2020-08-07 20:05 ` Ira Weiny 0 siblings, 1 reply; 2+ messages in thread From: Michael S. Tsirkin @ 2020-08-05 13:44 UTC (permalink / raw) To: linux-kernel; +Cc: linux-nvdimm Virtio pmem is modern-only. Use LE accessors for config space. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/nvdimm/virtio_pmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c index 5e3d07b47e0c..726c7354d465 100644 --- a/drivers/nvdimm/virtio_pmem.c +++ b/drivers/nvdimm/virtio_pmem.c @@ -58,9 +58,9 @@ static int virtio_pmem_probe(struct virtio_device *vdev) goto out_err; } - virtio_cread(vpmem->vdev, struct virtio_pmem_config, + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, start, &vpmem->start); - virtio_cread(vpmem->vdev, struct virtio_pmem_config, + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, size, &vpmem->size); res.start = vpmem->start; -- MST _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 33/38] virtio_pmem: convert to LE accessors 2020-08-05 13:44 ` [PATCH v3 33/38] virtio_pmem: convert to LE accessors Michael S. Tsirkin @ 2020-08-07 20:05 ` Ira Weiny 0 siblings, 0 replies; 2+ messages in thread From: Ira Weiny @ 2020-08-07 20:05 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: linux-kernel, linux-nvdimm On Wed, Aug 05, 2020 at 09:44:45AM -0400, Michael S. Tsirkin wrote: > Virtio pmem is modern-only. Use LE accessors for config space. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/nvdimm/virtio_pmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c > index 5e3d07b47e0c..726c7354d465 100644 > --- a/drivers/nvdimm/virtio_pmem.c > +++ b/drivers/nvdimm/virtio_pmem.c > @@ -58,9 +58,9 @@ static int virtio_pmem_probe(struct virtio_device *vdev) > goto out_err; > } > > - virtio_cread(vpmem->vdev, struct virtio_pmem_config, > + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, > start, &vpmem->start); > - virtio_cread(vpmem->vdev, struct virtio_pmem_config, > + virtio_cread_le(vpmem->vdev, struct virtio_pmem_config, > size, &vpmem->size); FWIW I think squashing patch 15/38 and this patch would have made more sense. Acked-by: Ira Weiny <ira.weiny@intel.com> > > res.start = vpmem->start; > -- > MST > _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-07 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200805134226.1106164-1-mst@redhat.com>
2020-08-05 13:44 ` [PATCH v3 33/38] virtio_pmem: convert to LE accessors Michael S. Tsirkin
2020-08-07 20:05 ` Ira Weiny
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox