From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>, "cai@lca.pw" <cai@lca.pw>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings
Date: Thu, 16 May 2019 00:25:18 +0000 [thread overview]
Message-ID: <7ba8164b60be4e41707559ed6623f9462c942735.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4gGwyPf0j4rXRM3JjsjGSHB6bGdZfwg+v2y8NQ6hNVK8g@mail.gmail.com>
On Wed, 2019-05-15 at 16:25 -0700, Dan Williams wrote:
>
> > diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> > index 4671776f5623..9f02a99cfac0 100644
> > --- a/drivers/nvdimm/btt.c
> > +++ b/drivers/nvdimm/btt.c
> > @@ -1269,11 +1269,9 @@ static int btt_read_pg(struct btt *btt, struct bio_integrity_payload *bip,
> >
> > ret = btt_data_read(arena, page, off, postmap, cur_len);
> > if (ret) {
> > - int rc;
> > -
> > /* Media error - set the e_flag */
> > - rc = btt_map_write(arena, premap, postmap, 0, 1,
> > - NVDIMM_IO_ATOMIC);
> > + btt_map_write(arena, premap, postmap, 0, 1,
> > + NVDIMM_IO_ATOMIC);
> > goto out_rtt;
>
> This doesn't look correct to me, shouldn't we at least be logging that
> the bad-block failed to be persistently tracked?
Yes logging it sounds good to me. Qian, can you include this in your
respin or shall I send a fix for it separately (since we were always
ignoring the failure here regardless of this patch)?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-05-16 0:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 15:07 [RESEND PATCH] nvdimm: fix some compilation warnings Qian Cai
2019-05-15 23:25 ` Dan Williams
2019-05-16 0:25 ` Verma, Vishal L [this message]
2019-05-16 0:26 ` Dan Williams
2019-05-16 0:29 ` Verma, Vishal L
2019-06-26 21:00 ` Qian Cai
2019-06-26 21:43 ` Verma, Vishal L
2019-05-16 0:31 ` Qian Cai
2019-05-16 0:34 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba8164b60be4e41707559ed6623f9462c942735.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox