* Re: [PATCH 1/3] libnvdimm: Fix memory leaks in of_pmem.c
@ 2020-08-18 19:00 Markus Elfring
2020-08-19 1:07 ` Leizhen (ThunderTown)
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-08-18 19:00 UTC (permalink / raw)
To: Zhen Lei, linux-nvdimm; +Cc: linux-kernel
> The memory priv->bus_desc.provider_name allocated by kstrdup() should be
> freed.
* Would an imperative wording be preferred for the change description?
* I propose to add the tag “Fixes” to the commit message.
Regards,
Markus
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] libnvdimm: Fix memory leaks in of_pmem.c
2020-08-18 19:00 [PATCH 1/3] libnvdimm: Fix memory leaks in of_pmem.c Markus Elfring
@ 2020-08-19 1:07 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 2+ messages in thread
From: Leizhen (ThunderTown) @ 2020-08-19 1:07 UTC (permalink / raw)
To: Markus Elfring, linux-nvdimm; +Cc: linux-kernel, Oliver
On 8/19/2020 3:00 AM, Markus Elfring wrote:
>> The memory priv->bus_desc.provider_name allocated by kstrdup() should be
>> freed.
>
> * Would an imperative wording be preferred for the change description?
>
> * I propose to add the tag “Fixes” to the commit message.
Thanks for your suggestion, I will add it in v2.
Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
>
> Regards,
> Markus
>
>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-19 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-18 19:00 [PATCH 1/3] libnvdimm: Fix memory leaks in of_pmem.c Markus Elfring
2020-08-19 1:07 ` Leizhen (ThunderTown)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox