Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH v2] nvmet: make nvmet_wq visible in sysfs
Date: Thu, 31 Oct 2024 06:50:09 +0000	[thread overview]
Message-ID: <019d19a4-cf4e-4405-8672-b371f116da22@nvidia.com> (raw)
In-Reply-To: <74fd4aa7-5d58-4493-a718-673143611989@linux.alibaba.com>

On 10/30/24 23:38, Guixin Liu wrote:
> Thanks for tunning the commit message, the new content looks good,
>
> but I see some words are joined together, "coresto" -> "cores to",
>
> "interferenceand" -> "interference and", and so on.
>
> Please change this when you applying the patch.
>
> Best Regards,
>
> Guixin Liu 

Here is the updated one :-

In some complex scenarios, we deploy multiple tasks on a single machine
(hybrid deployment), such as Docker containers for function computation
(background processing), real-time tasks, monitoring, event handling,
and management, along with an NVMe target server.

Each of these components is restricted to its own CPU cores to prevent
mutual interference and ensure strict isolation. To achieve this level
of isolation for nvmet_wq we need to  use sysfs tunables such as
cpumask that are currently not accessible.

Add WQ_SYSFS flag to alloc_workqueue() when creating nvmet_wq so
workqueue tunables are exported in the userspace via sysfs.

with this patch :-

nvme (nvme-6.13) # ls /sys/devices/virtual/workqueue/nvmet-wq/
affinity_scope  affinity_strict  cpumask  max_active  nice per_cpu
power  subsystem  uevent


-ck



  reply	other threads:[~2024-10-31  6:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  2:27 [PATCH v2] nvmet: make nvmet_wq visible in sysfs Guixin Liu
2024-10-31  6:23 ` Chaitanya Kulkarni
2024-10-31  6:38   ` Guixin Liu
2024-10-31  6:50     ` Chaitanya Kulkarni [this message]
2024-10-31  6:57       ` hch
2024-10-31  7:00       ` Guixin Liu
2024-11-05 16:36         ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=019d19a4-cf4e-4405-8672-b371f116da22@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=hch@lst.de \
    --cc=kanie@linux.alibaba.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox