Re: [PATCH v2] nvmet: make nvmet_wq visible in sysfs

[Guixin Liu <kanie@linux.alibaba.com>]

在 2024/10/31 14:50, Chaitanya Kulkarni 写道:
> On 10/30/24 23:38, Guixin Liu wrote:
>> Thanks for tunning the commit message, the new content looks good,
>>
>> but I see some words are joined together, "coresto" -> "cores to",
>>
>> "interferenceand" -> "interference and", and so on.
>>
>> Please change this when you applying the patch.
>>
>> Best Regards,
>>
>> Guixin Liu
> Here is the updated one :-
>
> In some complex scenarios, we deploy multiple tasks on a single machine
> (hybrid deployment), such as Docker containers for function computation
> (background processing), real-time tasks, monitoring, event handling,
> and management, along with an NVMe target server.
>
> Each of these components is restricted to its own CPU cores to prevent
> mutual interference and ensure strict isolation. To achieve this level
> of isolation for nvmet_wq we need to  use sysfs tunables such as
> cpumask that are currently not accessible.
>
> Add WQ_SYSFS flag to alloc_workqueue() when creating nvmet_wq so
> workqueue tunables are exported in the userspace via sysfs.
>
> with this patch :-
>
> nvme (nvme-6.13) # ls /sys/devices/virtual/workqueue/nvmet-wq/
> affinity_scope  affinity_strict  cpumask  max_active  nice per_cpu
> power  subsystem  uevent
>
>
> -ck
>
Looks good now, my deepest gratitude for the tunning.

Best Regards,

Guixin Liu