From: Jens Axboe <axboe@kernel.dk>
To: Kanchan Joshi <joshi.k@samsung.com>,
kbusch@kernel.org, linux-nvme@lists.infradead.org
Cc: csander@purestorage.com
Subject: Re: [PATCH v2] nvme: fix incorrect sizeof
Date: Tue, 6 May 2025 13:47:01 -0600 [thread overview]
Message-ID: <07af392f-fe4d-4e96-bd2c-392f64e82261@kernel.dk> (raw)
In-Reply-To: <20250506184843.25081-1-joshi.k@samsung.com>
On 5/6/25 12:48 PM, Kanchan Joshi wrote:
> The plid array, head->plids, is meant to store placement IDs, each of
> type u16. But its size has been incorrectly calculated, as the size of
> the pointer is being used instead of the size of the object it points
> to.
>
> Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.
For some reason this isn't on lore, I hand applied it.
--
Jens Axboe
prev parent reply other threads:[~2025-05-06 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250506185729epcas5p42c58afcb24ceb7be79babb63932677bb@epcas5p4.samsung.com>
2025-05-06 18:48 ` [PATCH v2] nvme: fix incorrect sizeof Kanchan Joshi
2025-05-06 19:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07af392f-fe4d-4e96-bd2c-392f64e82261@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox