[PATCH v2] nvme: fix incorrect sizeof

[PATCH v2] nvme: fix incorrect sizeof

[Kanchan Joshi]

The plid array, head->plids, is meant to store placement IDs, each of
type u16. But its size has been incorrectly calculated, as the size of
the pointer is being used instead of the size of the object it points
to.

Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.

Fixes: 38e8397dde63 ("nvme: use fdp streams if write stream is provided")
Reported-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
---
changes since v1:
- add reported-by (Jens)
- expand commit description (Jens)

 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 52331a14bce1..7c1b9f2bf0ae 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2296,7 +2296,7 @@ static int nvme_query_fdp_info(struct nvme_ns *ns, struct nvme_ns_info *info)
 	if (!head->nr_plids)
 		goto free;
 
-	head->plids = kcalloc(head->nr_plids, sizeof(head->plids),
+	head->plids = kcalloc(head->nr_plids, sizeof(*head->plids),
 			      GFP_KERNEL);
 	if (!head->plids) {
 		dev_warn(ctrl->device,
-- 
2.25.1

Re: [PATCH v2] nvme: fix incorrect sizeof

[Jens Axboe]

On 5/6/25 12:48 PM, Kanchan Joshi wrote:
> The plid array, head->plids, is meant to store placement IDs, each of
> type u16. But its size has been incorrectly calculated, as the size of
> the pointer is being used instead of the size of the object it points
> to.
> 
> Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.

For some reason this isn't on lore, I hand applied it.

-- 
Jens Axboe