From: Nilay Shroff <nilay@linux.ibm.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, hare@kernel.org,
kbusch@kernel.org, gjoyce@ibm.com
Subject: Re: [PATCHv2 2/4] tree: add queue-depth attribute for nvme path object
Date: Wed, 23 Apr 2025 11:43:54 +0530 [thread overview]
Message-ID: <0b9d9fdc-6cf9-4140-a73d-01671de4b997@linux.ibm.com> (raw)
In-Reply-To: <ad838a6d-6180-4c00-85b2-448393689478@flourine.local>
On 4/22/25 10:53 PM, Daniel Wagner wrote:
> On Tue, Apr 22, 2025 at 08:02:49PM +0530, Nilay Shroff wrote:
>>> As discussed: saving the 'queue_depth' attribute is a bad idea, as it
>>> changes frequently.
>>> I'd rather read the attribute value from sysfs whenever
>>> 'nvme_path_get_queue_depth' is called, and use the tree structure only
>>> to hold the pathname.
>>>
>> Yes correct, but I thought we discussed about implementing non-cached
>> version of API in libnvme 2.x. So I implemented cached version of
>> queue_depth API. Daniel can you confirm?
>
> I was under the impression that we agreed on the default being
> non-cached. As it doesn't really make sense to have a cached anyway.
Okay, my bad.. probably some misunderstanding on my part.
I will fix this in the next version of this patch.
Thanks,
--Nilay
next prev parent reply other threads:[~2025-04-23 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 13:59 [PATCHv2 0/4] libnvme: add support for discovering multipath of a shared ns Nilay Shroff
2025-04-17 13:59 ` [PATCHv2 1/4] tree: add support for discovering nvme paths using sysfs multipath link Nilay Shroff
2025-04-22 6:24 ` Hannes Reinecke
2025-04-22 14:01 ` Nilay Shroff
2025-04-17 13:59 ` [PATCHv2 2/4] tree: add queue-depth attribute for nvme path object Nilay Shroff
2025-04-22 6:26 ` Hannes Reinecke
2025-04-22 14:32 ` Nilay Shroff
2025-04-22 17:23 ` Daniel Wagner
2025-04-23 6:13 ` Nilay Shroff [this message]
2025-04-17 13:59 ` [PATCHv2 3/4] tree: add attribute numa_nodes for NVMe " Nilay Shroff
2025-04-22 6:27 ` Hannes Reinecke
2025-04-17 13:59 ` [PATCHv2 4/4] test: extend sysfs tree dump test Nilay Shroff
2025-04-22 6:28 ` Hannes Reinecke
2025-04-22 10:09 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b9d9fdc-6cf9-4140-a73d-01671de4b997@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=dwagner@suse.de \
--cc=gjoyce@ibm.com \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox