Re: [PATCHv2 4/4] test: extend sysfs tree dump test

[Hannes Reinecke <hare@suse.de>]

On 4/17/25 15:59, Nilay Shroff wrote:
> In order to validate multipath link support extend the existing sysfs
> tree dump test.
> 
> The updated tree-pcie.tar.xz archive includes a sysfs dump with two
> NVMe subsystems. The nvme-subsys0 simulates a single-port NVMe disk
> with a private namespace that does not support multipath. And another
> nvme-subsys1 simulates a dual-port NVMe disk with a shared namespace
> attached to multiple controllers.
> 
> The json tree dump is also updated to include NVMe namespace path
> information. Since the archive content has changed, the expected
> output file tree-pcie.out is also updated to reflect the new structure.
> 
> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
> ---
>   src/nvme/json.c                  |  90 +++++++++++++++++++++++++++----
>   test/sysfs/data/tree-pcie.out    |  53 ++++++++++++++----
>   test/sysfs/data/tree-pcie.tar.xz | Bin 19712 -> 12656 bytes
>   3 files changed, 124 insertions(+), 19 deletions(-)
> 
Not a big fan of having tar.gz files in git. Can't we create it on the
fly and only store text files?

Otherwise:

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich