From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Sagi Grimberg <sagi@grimberg.me>,
James Smart <jsmart2021@gmail.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH blktests v3 00/13] Switch to allowed_host
Date: Fri, 11 Aug 2023 12:29:17 +0200 [thread overview]
Message-ID: <0bdc92a4-5eee-075b-2357-27cac97aa524@suse.de> (raw)
In-Reply-To: <20230811093614.28005-1-dwagner@suse.de>
On 8/11/23 11:36, Daniel Wagner wrote:
> Addressed the comments from v2. I also added cleanup code to _nvmet_cleanup() to
> make sure we do not leak resources when something goes wrong. I run into this
> while testing and all tests after the first failure failed then.
>
> changes:
> v3:
> - added new patch: "nvme/043: Use hostnqn to generate DHCAP key"
> - removed unused variable in "nvme/rc: Add helper for adding/removing to allow list"
> - added cleanup code to _nvmet_cleanup().
>
> v2:
> - updated commit messages
> - moved the removal of subsys_name to the right patch
> - added _nvmet_target_{setup|cleanup} helpers
> this addresses also the 'appears unused' warning by ShellCheck
> - https://lore.kernel.org/linux-nvme/20230810111317.25273-1-dwagner@suse.de/
>
> v1:
> - initial version
> https://lore.kernel.org/linux-nvme/20230726124644.12619-1-dwagner@suse.de/
> Looks good.
You can add:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Frankenstr. 146, 90461 Nürnberg
Managing Directors: I. Totev, A. Myers, A. McDonald, M. B. Moerman
(HRB 36809, AG Nürnberg)
next prev parent reply other threads:[~2023-08-11 10:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 9:36 [PATCH blktests v3 00/13] Switch to allowed_host Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 01/13] nvme/{003,004,005,013,046,049}: Group all variables declarations Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 02/13] nvme: Reorganize test preamble code section Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 03/13] nvme/043: Use hostnqn to generate DHCAP key Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 04/13] nvme/rc: Add common subsystem nqn define Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 05/13] nvme: Use def_subsysnqn variable instead local variable Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 06/13] nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and hostid Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 07/13] nvme/rc: Add common file_path name define Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 08/13] nvme: Use def_file_path variable instead local variable Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 09/13] nvme/rc: Add common def_subsys_uuid define Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 10/13] nvme: Use def_subsys_uuid variable Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 11/13] nvme/rc: Add helper for adding/removing to allow list Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 12/13] nvme: Add explicitly host to allow_host list Daniel Wagner
2023-08-11 9:36 ` [PATCH blktests v3 13/13] nvme: Introduce nvmet_target_{setup/cleanup} common code Daniel Wagner
2023-08-13 14:55 ` Sagi Grimberg
2023-08-16 9:28 ` Daniel Wagner
2023-08-17 8:33 ` Sagi Grimberg
2023-08-11 10:29 ` Hannes Reinecke [this message]
2023-08-13 14:59 ` [PATCH blktests v3 00/13] Switch to allowed_host Sagi Grimberg
2023-08-16 9:31 ` Daniel Wagner
2023-08-16 12:18 ` Shinichiro Kawasaki
2023-08-17 2:58 ` Shinichiro Kawasaki
2023-08-17 8:25 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bdc92a4-5eee-075b-2357-27cac97aa524@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=jsmart2021@gmail.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox