public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
	James Smart <jsmart2021@gmail.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v3 00/13] Switch to allowed_host
Date: Fri, 11 Aug 2023 11:36:01 +0200	[thread overview]
Message-ID: <20230811093614.28005-1-dwagner@suse.de> (raw)

Addressed the comments from v2. I also added cleanup code to _nvmet_cleanup() to
make sure we do not leak resources when something goes wrong. I run into this
while testing and all tests after the first failure failed then.

changes:
v3:
 - added new patch: "nvme/043: Use hostnqn to generate DHCAP key"
 - removed unused variable in "nvme/rc: Add helper for adding/removing to allow list"
 - added cleanup code to _nvmet_cleanup().

v2:
 - updated commit messages
 - moved the removal of subsys_name to the right patch
 - added _nvmet_target_{setup|cleanup} helpers
   this addresses also the 'appears unused' warning by ShellCheck
 - https://lore.kernel.org/linux-nvme/20230810111317.25273-1-dwagner@suse.de/

v1:
 - initial version
   https://lore.kernel.org/linux-nvme/20230726124644.12619-1-dwagner@suse.de/


*** BLURB HERE ***

Daniel Wagner (13):
  nvme/{003,004,005,013,046,049}: Group all variables declarations
  nvme: Reorganize test preamble code section
  nvme/043: Use hostnqn to generate DHCAP key
  nvme/rc: Add common subsystem nqn define
  nvme: Use def_subsysnqn variable instead local variable
  nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and
    hostid
  nvme/rc: Add common file_path name define
  nvme: Use def_file_path variable instead local variable
  nvme/rc: Add common def_subsys_uuid define
  nvme: Use def_subsys_uuid variable
  nvme/rc: Add helper for adding/removing to allow list
  nvme: Add explicitly host to allow_host list
  nvme: Introduce nvmet_target_{setup/cleanup} common code

 tests/nvme/003 | 12 ++-----
 tests/nvme/004 | 23 ++++--------
 tests/nvme/005 | 22 +++---------
 tests/nvme/006 | 21 ++---------
 tests/nvme/007 | 19 ++--------
 tests/nvme/008 | 26 +++-----------
 tests/nvme/009 | 21 +++--------
 tests/nvme/010 | 26 +++-----------
 tests/nvme/011 | 22 +++---------
 tests/nvme/012 | 26 +++-----------
 tests/nvme/013 | 22 +++---------
 tests/nvme/014 | 26 +++-----------
 tests/nvme/015 | 21 +++--------
 tests/nvme/016 | 17 +++++----
 tests/nvme/017 | 26 ++++++--------
 tests/nvme/018 | 21 +++--------
 tests/nvme/019 | 26 +++-----------
 tests/nvme/020 | 21 +++--------
 tests/nvme/021 | 21 +++--------
 tests/nvme/022 | 21 +++--------
 tests/nvme/023 | 26 +++-----------
 tests/nvme/024 | 21 +++--------
 tests/nvme/025 | 21 +++--------
 tests/nvme/026 | 21 +++--------
 tests/nvme/027 | 20 +++--------
 tests/nvme/028 | 20 +++--------
 tests/nvme/029 | 26 +++-----------
 tests/nvme/030 | 19 +++++-----
 tests/nvme/031 | 14 ++++----
 tests/nvme/033 |  9 ++---
 tests/nvme/034 |  9 ++---
 tests/nvme/035 |  9 ++---
 tests/nvme/036 |  9 ++---
 tests/nvme/037 |  8 ++---
 tests/nvme/038 |  6 ++--
 tests/nvme/039 |  4 +--
 tests/nvme/040 | 28 +++++----------
 tests/nvme/041 | 49 ++++++++-----------------
 tests/nvme/042 | 55 ++++++++++------------------
 tests/nvme/043 | 52 +++++++++------------------
 tests/nvme/044 | 71 ++++++++++++++----------------------
 tests/nvme/045 | 62 ++++++++++++--------------------
 tests/nvme/046 |  1 +
 tests/nvme/047 | 30 ++++------------
 tests/nvme/048 | 42 +++++++---------------
 tests/nvme/049 |  1 +
 tests/nvme/rc  | 97 +++++++++++++++++++++++++++++++++++++++++++++++---
 47 files changed, 404 insertions(+), 766 deletions(-)

-- 
2.41.0



             reply	other threads:[~2023-08-11  9:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  9:36 Daniel Wagner [this message]
2023-08-11  9:36 ` [PATCH blktests v3 01/13] nvme/{003,004,005,013,046,049}: Group all variables declarations Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 02/13] nvme: Reorganize test preamble code section Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 03/13] nvme/043: Use hostnqn to generate DHCAP key Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 04/13] nvme/rc: Add common subsystem nqn define Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 05/13] nvme: Use def_subsysnqn variable instead local variable Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 06/13] nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and hostid Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 07/13] nvme/rc: Add common file_path name define Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 08/13] nvme: Use def_file_path variable instead local variable Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 09/13] nvme/rc: Add common def_subsys_uuid define Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 10/13] nvme: Use def_subsys_uuid variable Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 11/13] nvme/rc: Add helper for adding/removing to allow list Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 12/13] nvme: Add explicitly host to allow_host list Daniel Wagner
2023-08-11  9:36 ` [PATCH blktests v3 13/13] nvme: Introduce nvmet_target_{setup/cleanup} common code Daniel Wagner
2023-08-13 14:55   ` Sagi Grimberg
2023-08-16  9:28     ` Daniel Wagner
2023-08-17  8:33       ` Sagi Grimberg
2023-08-11 10:29 ` [PATCH blktests v3 00/13] Switch to allowed_host Hannes Reinecke
2023-08-13 14:59 ` Sagi Grimberg
2023-08-16  9:31   ` Daniel Wagner
2023-08-16 12:18     ` Shinichiro Kawasaki
2023-08-17  2:58       ` Shinichiro Kawasaki
2023-08-17  8:25         ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230811093614.28005-1-dwagner@suse.de \
    --to=dwagner@suse.de \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=jsmart2021@gmail.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=sagi@grimberg.me \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox