From: Hannes Reinecke <hare@suse.de>
To: Nilay Shroff <nilay@linux.ibm.com>,
Sagi Grimberg <sagi@grimberg.me>,
hare@kernel.org, Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] nvmet: move percpu handling into nvmet_ns_{enable,disable}
Date: Fri, 24 Jan 2025 16:09:53 +0100 [thread overview]
Message-ID: <0f18f1ec-5164-483b-99ec-2c6afdb45675@suse.de> (raw)
In-Reply-To: <c125b796-d1f7-4c6a-8e96-79aa80143456@linux.ibm.com>
On 1/24/25 15:06, Nilay Shroff wrote:
>
>
[ .. ]>
> Though I was never able to recreate this issue on my setup even after running
> nvme/058 hundreds of times, still I think the issue reported by Shinichiro
> appears plausible. So we need this fix and your changes look good to me.
>
> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
Yeah, we definitely need this. I was able to trigger it quite
consistently with qemu after just a few retries.
And I guess we can now kill the ->enable setting completely, and
just use the xarray mark instead.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-01-24 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 8:25 [PATCH] nvmet: move percpu handling into nvmet_ns_{enable,disable} hare
2025-01-24 10:50 ` Sagi Grimberg
2025-01-24 11:09 ` Hannes Reinecke
2025-01-24 14:06 ` Nilay Shroff
2025-01-24 15:09 ` Hannes Reinecke [this message]
2025-01-24 15:20 ` Nilay Shroff
2025-01-26 8:04 ` Sagi Grimberg
2025-01-28 7:46 ` Christoph Hellwig
2025-01-24 19:59 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f18f1ec-5164-483b-99ec-2c6afdb45675@suse.de \
--to=hare@suse.de \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox