From: Keith Busch <kbusch@kernel.org>
To: hare@kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: move percpu handling into nvmet_ns_{enable,disable}
Date: Fri, 24 Jan 2025 12:59:39 -0700 [thread overview]
Message-ID: <Z5PxKynpEA71LKVV@kbusch-mbp> (raw)
In-Reply-To: <20250124082505.140258-1-hare@kernel.org>
On Fri, Jan 24, 2025 at 09:25:05AM +0100, hare@kernel.org wrote:
> From: Hannes Reinecke <hare@kernel.org>
>
> The namespace percpu counter protects pending I/O, and we can
> only safely diable the namespace once the counter drop to zero.
> So we need to init the percpu counter in nvmet_ns_enable(), and
> wait for it to drop to zero in nvmet_ns_disable() to avoid having
> I/O pending after the namespace has been disabled.
>
> Fixes: 74d16965d7ac ("nvmet-loop: avoid using mutex in IO hotpath")
We'll have to wait for after the merge window when the block tree merges
up to apply this: the nvme-6.14 branch doesn't contain the offending
commit yet.
prev parent reply other threads:[~2025-01-24 19:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 8:25 [PATCH] nvmet: move percpu handling into nvmet_ns_{enable,disable} hare
2025-01-24 10:50 ` Sagi Grimberg
2025-01-24 11:09 ` Hannes Reinecke
2025-01-24 14:06 ` Nilay Shroff
2025-01-24 15:09 ` Hannes Reinecke
2025-01-24 15:20 ` Nilay Shroff
2025-01-26 8:04 ` Sagi Grimberg
2025-01-28 7:46 ` Christoph Hellwig
2025-01-24 19:59 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5PxKynpEA71LKVV@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox