From: Martin Wilck <mwilck@suse.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/3] blktests: nvme: skip passthru tests on multipath devices
Date: Fri, 23 Aug 2024 08:41:59 +0200 [thread overview]
Message-ID: <1106fb07918468cb8cacb35ef0448573ec7be156.camel@suse.com> (raw)
In-Reply-To: <d1282549-f037-4556-93f7-adb3d890db82@flourine.local>
On Fri, 2024-08-23 at 08:35 +0200, Daniel Wagner wrote:
> On Thu, Aug 22, 2024 at 09:38:12PM GMT, Martin Wilck wrote:
> > +_require_test_dev_is_nvme_no_mpath() {
> > + if [[ "$(readlink -f "$TEST_DEV_SYSFS/device")" =~ /nvme-
> > subsystem/ ]]; then
> > + SKIP_REASONS+=("$TEST_DEV is a NVMe multipath
> > device")
> > + return 1
> > + fi
> > + return 0
> > +}
>
> Just a nit: what about _require_test_dev_is_native_multipath?
The intention was to require a device that is _not_ a native multipath
device. Change it to "_require_test_dev_is_not_native_multipath"?
Thanks,
Martin
next prev parent reply other threads:[~2024-08-23 6:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 19:38 [PATCH 1/3] blktests: nvme: skip passthru tests on multipath devices Martin Wilck
2024-08-22 19:38 ` [PATCH 2/3] blktests: nvme/032: skip on non-PCI devices Martin Wilck
2024-08-23 6:46 ` Daniel Wagner
2024-08-22 19:38 ` [PATCH 3/3] nvme: add test for controller rescan under I/O load Martin Wilck
2024-08-23 6:45 ` Daniel Wagner
2024-08-23 6:50 ` Martin Wilck
2024-08-23 7:03 ` Daniel Wagner
2024-08-23 10:18 ` Nilay Shroff
2024-08-23 13:39 ` Nilay Shroff
2024-08-23 14:49 ` Martin Wilck
2024-08-23 6:35 ` [PATCH 1/3] blktests: nvme: skip passthru tests on multipath devices Daniel Wagner
2024-08-23 6:41 ` Martin Wilck [this message]
2024-08-23 7:07 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106fb07918468cb8cacb35ef0448573ec7be156.camel@suse.com \
--to=mwilck@suse.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox