From: Martin Wilck <martin.wilck@suse.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Martin Wilck <mwilck@suse.com>
Subject: [PATCH 1/3] blktests: nvme: skip passthru tests on multipath devices
Date: Thu, 22 Aug 2024 21:38:12 +0200 [thread overview]
Message-ID: <20240822193814.106111-1-mwilck@suse.com> (raw)
NVMe multipath devices have no associated character device that
can be used for NVMe passtrhu. Skip them.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
tests/nvme/033 | 4 ++++
tests/nvme/034 | 4 ++++
tests/nvme/035 | 1 +
tests/nvme/036 | 4 ++++
tests/nvme/037 | 4 ++++
tests/nvme/039 | 4 ++++
tests/nvme/rc | 8 ++++++++
7 files changed, 29 insertions(+)
diff --git a/tests/nvme/033 b/tests/nvme/033
index 7a69b94..dda0763 100755
--- a/tests/nvme/033
+++ b/tests/nvme/033
@@ -13,6 +13,10 @@ requires() {
_have_kernel_option NVME_TARGET_PASSTHRU
}
+device_requires() {
+ _require_test_dev_is_nvme_no_mpath
+}
+
set_conditions() {
_set_nvme_trtype "$@"
}
diff --git a/tests/nvme/034 b/tests/nvme/034
index 239757c..41f1542 100755
--- a/tests/nvme/034
+++ b/tests/nvme/034
@@ -14,6 +14,10 @@ requires() {
_have_fio
}
+device_requires() {
+ _require_test_dev_is_nvme_no_mpath
+}
+
set_conditions() {
_set_nvme_trtype "$@"
}
diff --git a/tests/nvme/035 b/tests/nvme/035
index 8286178..4357efa 100755
--- a/tests/nvme/035
+++ b/tests/nvme/035
@@ -17,6 +17,7 @@ requires() {
}
device_requires() {
+ _require_test_dev_is_nvme_no_mpath
_require_test_dev_size "${NVME_IMG_SIZE}"
}
diff --git a/tests/nvme/036 b/tests/nvme/036
index ef6c29d..3a28cb7 100755
--- a/tests/nvme/036
+++ b/tests/nvme/036
@@ -13,6 +13,10 @@ requires() {
_have_kernel_option NVME_TARGET_PASSTHRU
}
+device_requires() {
+ _require_test_dev_is_nvme_no_mpath
+}
+
set_conditions() {
_set_nvme_trtype "$@"
}
diff --git a/tests/nvme/037 b/tests/nvme/037
index ef7ac59..557d491 100755
--- a/tests/nvme/037
+++ b/tests/nvme/037
@@ -12,6 +12,10 @@ requires() {
_have_kernel_option NVME_TARGET_PASSTHRU
}
+device_requires() {
+ _require_test_dev_is_nvme_no_mpath
+}
+
set_conditions() {
_set_nvme_trtype "$@"
}
diff --git a/tests/nvme/039 b/tests/nvme/039
index a0f135c..ff8c1eb 100755
--- a/tests/nvme/039
+++ b/tests/nvme/039
@@ -18,6 +18,10 @@ requires() {
_have_kernel_option FAULT_INJECTION_DEBUG_FS
}
+device_requires() {
+ _require_test_dev_is_nvme_no_mpath
+}
+
# Get the last dmesg lines as many as specified. Exclude the lines to indicate
# suppression by rate limit.
last_dmesg()
diff --git a/tests/nvme/rc b/tests/nvme/rc
index dedc412..b3b1149 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -130,6 +130,14 @@ _require_test_dev_is_nvme() {
return 0
}
+_require_test_dev_is_nvme_no_mpath() {
+ if [[ "$(readlink -f "$TEST_DEV_SYSFS/device")" =~ /nvme-subsystem/ ]]; then
+ SKIP_REASONS+=("$TEST_DEV is a NVMe multipath device")
+ return 1
+ fi
+ return 0
+}
+
_require_nvme_test_img_size() {
local require_sz_mb
local nvme_img_size_mb
--
2.46.0
next reply other threads:[~2024-08-22 19:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 19:38 Martin Wilck [this message]
2024-08-22 19:38 ` [PATCH 2/3] blktests: nvme/032: skip on non-PCI devices Martin Wilck
2024-08-23 6:46 ` Daniel Wagner
2024-08-22 19:38 ` [PATCH 3/3] nvme: add test for controller rescan under I/O load Martin Wilck
2024-08-23 6:45 ` Daniel Wagner
2024-08-23 6:50 ` Martin Wilck
2024-08-23 7:03 ` Daniel Wagner
2024-08-23 10:18 ` Nilay Shroff
2024-08-23 13:39 ` Nilay Shroff
2024-08-23 14:49 ` Martin Wilck
2024-08-23 6:35 ` [PATCH 1/3] blktests: nvme: skip passthru tests on multipath devices Daniel Wagner
2024-08-23 6:41 ` Martin Wilck
2024-08-23 7:07 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822193814.106111-1-mwilck@suse.com \
--to=martin.wilck@suse.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox