From: Sagi Grimberg <sagi@grimberg.me>
To: Keith Busch <kbusch@kernel.org>, Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de
Subject: Re: [PATCH 1/2] nvme-core: add ctrl state transition debug helper
Date: Thu, 7 Mar 2024 10:03:35 +0200 [thread overview]
Message-ID: <11986ab8-0491-4e64-b503-ec1ecc440830@grimberg.me> (raw)
In-Reply-To: <ZedJeFUpuogtBSd5@kbusch-mbp.mynextlight.net>
On 05/03/2024 18:34, Keith Busch wrote:
> On Sun, Feb 11, 2024 at 08:26:40PM -0800, Chaitanya Kulkarni wrote:
>> @@ -621,6 +636,9 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
>> }
>>
>> if (changed) {
>> + dev_dbg(ctrl->device, "%s %s -> %s\n", __func__,
>> + nvme_ctrl_state_str(old_state),
>> + nvme_ctrl_state_str(new_state));
>> WRITE_ONCE(ctrl->state, new_state);
>> wake_up_all(&ctrl->state_wq);
>> }
> Turing the system logs up to debug level might get you a whole lot of
> unrelated stuff. Could a new trace_event get you what you need instead?
> There's more fine grain control on those.
>
I actually think its useful here as is, dynamic debug can also turn on
debug per function.
next prev parent reply other threads:[~2024-03-07 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240212070024epcas5p15af7a6b038a30b3918adc517641b8eb1@epcas5p1.samsung.com>
2024-02-12 4:26 ` [PATCH 1/2] nvme-core: add ctrl state transition debug helper Chaitanya Kulkarni
2024-02-12 4:26 ` [PATCH 2/2] nvme: export and use previously added helper Chaitanya Kulkarni
2024-02-12 6:54 ` Nitesh Shetty
2024-03-07 8:03 ` Sagi Grimberg
2024-02-12 6:53 ` [PATCH 1/2] nvme-core: add ctrl state transition debug helper Nitesh Shetty
2024-02-21 5:34 ` Chaitanya Kulkarni
2024-03-05 4:34 ` Chaitanya Kulkarni
2024-03-05 16:34 ` Keith Busch
2024-03-06 5:21 ` Chaitanya Kulkarni
2024-03-07 8:03 ` Sagi Grimberg [this message]
2024-03-07 8:03 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11986ab8-0491-4e64-b503-ec1ecc440830@grimberg.me \
--to=sagi@grimberg.me \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox