Re: [PATCH 1/2] nvme-core: add ctrl state transition debug helper

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 3/5/24 08:34, Keith Busch wrote:
> On Sun, Feb 11, 2024 at 08:26:40PM -0800, Chaitanya Kulkarni wrote:
>> @@ -621,6 +636,9 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
>>   	}
>>   
>>   	if (changed) {
>> +		dev_dbg(ctrl->device, "%s %s -> %s\n", __func__,
>> +			nvme_ctrl_state_str(old_state),
>> +			nvme_ctrl_state_str(new_state));
>>   		WRITE_ONCE(ctrl->state, new_state);
>>   		wake_up_all(&ctrl->state_wq);
>>   	}
> Turing the system logs up to debug level might get you a whole lot of
> unrelated stuff. Could a new trace_event get you what you need instead?
> There's more fine grain control on those.

totally agree with you, I have patches to add few more tracepoints
I'll add v2 to that series and post soon, thanks for the suggestion ...

-ck