Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: james.smart@broadcom.com (James Smart)
Subject: [PATCH v2 10/10] nvme-cli: nvmf auto-connect scripts
Date: Wed, 24 Jul 2019 09:38:46 -0700	[thread overview]
Message-ID: <1215e814-30f7-85e6-a9b9-fd7d2c725654@broadcom.com> (raw)
In-Reply-To: <2297e9f3-4a9d-e759-5633-aeefe736b09c@grimberg.me>

On 7/23/2019 10:32 AM, Sagi Grimberg wrote:
>
>>>> +# Events from persistent discovery controllers or nvme-fc 
>>>> transport events
>>>> +ACTION=="change", SUBSYSTEM=="nvme", ENV{NVME_EVENT}=="discovery",\
>>>> +? ENV{NVME_CTRL_NAME}=="*", ENV{NVME_TRTYPE}=="*", 
>>>> ENV{NVME_TRADDR}=="*", \
>>>> +? ENV{NVME_TRSVCID}=="*", ENV{NVME_HOST_TRADDR}=="*", \
>>>> +? RUN+="/usr/bin/systemctl --no-block start 
>>>> nvmf-connect at --device=$env{NVME_CTRL_NAME}\t--transport=$env{NVME_TRTYPE}\t--traddr=$env{NVME_TRADDR}\t--trsvcid=$env{NVME_TRSVCID}\t--host-traddr=$env{NVME_HOST_TRADDR}.service" 
>>>>
>>>
>>> James, shouldn't this be /bin/systemctl?
>>
>> I don't believe so.?? On the distros I checked, /bin/systemctl is a 
>> soft or hard link to /usr/bin/systemctl
>
> Not always the case. Lets change that to /bin/systemctl.

I have no problem changing it, but am wondering what resource is giving 
you the reference locations. I can't find anything that actually 
specifies the location with some having /bin and others /usr/bin. The 
other files seem to lean toward a preference of /usr/bin.

-- james

references that didn't help:
http://www.tldp.org/LDP/Linux-Filesystem-Hierarchy/html
https://www.freedesktop.org/wiki/Software/systemd/

  reply	other threads:[~2019-07-24 16:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19 22:52 [PATCH v2 00/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-19 22:52 ` [PATCH v2 01/10] nvme-cli: ignore arguments that pass in "none" James Smart
2019-07-19 22:52 ` [PATCH v2 02/10] nvme-cli: support persistent connections to a discovery controller James Smart
2019-07-19 22:52 ` [PATCH v2 03/10] nvme-cli: allow discover to address discovery controller by persistent name James Smart
2019-07-19 22:52 ` [PATCH v2 04/10] nvme-cli: Refactor to create a get_nvme_ctrl_info routine James Smart
2019-07-19 22:53 ` [PATCH v2 05/10] nvme-cli: extend ctrl_list_item for connect attributes James Smart
2019-07-19 22:53 ` [PATCH v2 06/10] nvme-cli: Add routine to compare ctrl_list_item to connect args James Smart
2019-07-19 22:53 ` [PATCH v2 07/10] nvme-cli: Add routine to search for controller with specific attributes James Smart
2019-07-20  8:25   ` Minwoo Im
2019-07-20 18:33     ` James Smart
2019-07-22 22:41     ` Sagi Grimberg
2019-07-23 13:36       ` Minwoo Im
2019-07-19 22:53 ` [PATCH v2 08/10] nvme-cli: Expand --device argument processing James Smart
2019-07-19 22:53 ` [PATCH v2 09/10] nvme-cli: add --quiet option James Smart
2019-07-19 22:53 ` [PATCH v2 10/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-23  2:52   ` Sagi Grimberg
2019-07-23 16:01     ` James Smart
2019-07-23  3:57   ` Sagi Grimberg
2019-07-23 16:04     ` James Smart
2019-07-23 17:32       ` Sagi Grimberg
2019-07-24 16:38         ` James Smart [this message]
2019-07-24 18:15           ` Sagi Grimberg
2019-07-24 23:45             ` James Smart
2019-07-22 22:43 ` [PATCH v2 00/10] " Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215e814-30f7-85e6-a9b9-fd7d2c725654@broadcom.com \
    --to=james.smart@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox