From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH v2 07/10] nvme-cli: Add routine to search for controller with specific attributes
Date: Tue, 23 Jul 2019 22:36:17 +0900 [thread overview]
Message-ID: <20190723133617.GC7148@minwoo-desktop> (raw)
In-Reply-To: <f020727d-28c9-ff5b-3caa-f4258284bdec@grimberg.me>
On 19-07-22 15:41:08, Sagi Grimberg wrote:
>
> > James,
> >
> > It might be too late to discuss about this argument, but did you decided
> > to have (struct connect_args) as a parameter for this function?
> >
> > Sorry for not giving any thoughts on the following mail[1], but I would
> > prefer not introducing a new data structure for this because it's just a
> > bypass argument from a perspective of find_ctrl_with_connetargs(). But
> > If you think it's okay to go with, then I'm fine with that too.
>
> I think its just fine with the connect_args. This can also extend to
> other search/match functionality we may need in the future (that is
> insensitive to short/long args).
Agreed. I think it's good to go with what James just got sent.
Thanks for the clarification, Sagi!
next prev parent reply other threads:[~2019-07-23 13:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 22:52 [PATCH v2 00/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-19 22:52 ` [PATCH v2 01/10] nvme-cli: ignore arguments that pass in "none" James Smart
2019-07-19 22:52 ` [PATCH v2 02/10] nvme-cli: support persistent connections to a discovery controller James Smart
2019-07-19 22:52 ` [PATCH v2 03/10] nvme-cli: allow discover to address discovery controller by persistent name James Smart
2019-07-19 22:52 ` [PATCH v2 04/10] nvme-cli: Refactor to create a get_nvme_ctrl_info routine James Smart
2019-07-19 22:53 ` [PATCH v2 05/10] nvme-cli: extend ctrl_list_item for connect attributes James Smart
2019-07-19 22:53 ` [PATCH v2 06/10] nvme-cli: Add routine to compare ctrl_list_item to connect args James Smart
2019-07-19 22:53 ` [PATCH v2 07/10] nvme-cli: Add routine to search for controller with specific attributes James Smart
2019-07-20 8:25 ` Minwoo Im
2019-07-20 18:33 ` James Smart
2019-07-22 22:41 ` Sagi Grimberg
2019-07-23 13:36 ` Minwoo Im [this message]
2019-07-19 22:53 ` [PATCH v2 08/10] nvme-cli: Expand --device argument processing James Smart
2019-07-19 22:53 ` [PATCH v2 09/10] nvme-cli: add --quiet option James Smart
2019-07-19 22:53 ` [PATCH v2 10/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-23 2:52 ` Sagi Grimberg
2019-07-23 16:01 ` James Smart
2019-07-23 3:57 ` Sagi Grimberg
2019-07-23 16:04 ` James Smart
2019-07-23 17:32 ` Sagi Grimberg
2019-07-24 16:38 ` James Smart
2019-07-24 18:15 ` Sagi Grimberg
2019-07-24 23:45 ` James Smart
2019-07-22 22:43 ` [PATCH v2 00/10] " Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723133617.GC7148@minwoo-desktop \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox