From: james_p_freyensee@linux.intel.com (Jay Freyensee)
Subject: [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag
Date: Thu, 22 Sep 2016 15:37:20 -0700 [thread overview]
Message-ID: <1474583840-23739-1-git-send-email-james_p_freyensee@linux.intel.com> (raw)
I am not sure if it matters too much except in possibly
human usage understanding, but '-r' is used in the 'discover'
command for --raw. Change the --reconnect-delay flag
single letter to something not being used in any fabrics
command.
Signed-off-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
---
fabrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fabrics.c b/fabrics.c
index dff5d6a..5e892fb 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -759,7 +759,7 @@ int connect(const char *desc, int argc, char **argv)
"number of io queues to use (default is core count)" },
{"keep-alive-tmo", 'k', "LIST", CFG_STRING, &cfg.keep_alive_tmo, required_argument,
"keep alive timeout period in seconds" },
- {"reconnect-delay", 'r', "LIST", CFG_STRING, &cfg.reconnect_delay, required_argument,
+ {"reconnect-delay", 'c', "LIST", CFG_STRING, &cfg.reconnect_delay, required_argument,
"reconnect timeout period in seconds" },
{0},
};
--
2.7.4
next reply other threads:[~2016-09-22 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 22:37 Jay Freyensee [this message]
2016-09-23 3:33 ` [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flag Christoph Hellwig
2016-09-23 14:49 ` Steve Wise
2016-09-23 15:00 ` Keith Busch
2016-09-23 16:43 ` J Freyensee
2016-09-23 20:59 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474583840-23739-1-git-send-email-james_p_freyensee@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox