From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
tytso@mit.edu, nilay@linux.ibm.com, martin.petersen@oracle.com,
djwong@kernel.org, mcgrof@infradead.org
Subject: Re: [RFC PATCH] nvme: add an opt-in to use AWUPF
Date: Thu, 21 Aug 2025 11:33:25 +0100 [thread overview]
Message-ID: <14bfcc0e-ec43-4876-9b45-1f2824e1b059@oracle.com> (raw)
In-Reply-To: <20250821083537.GB29224@lst.de>
On 21/08/2025 09:35, Christoph Hellwig wrote:
>> + list_for_each_entry(tmp, &subsys->ctrls, subsys_entry)
>> + nvme_queue_scan(tmp);
> queueing a full rescan here seems expensive. What about just keeping
> the awupf value in our internal data structures and always use it
> for the physical block size calculation,
is that even ok? physical block size implies atomicity also.
> but only apply it to the
> atomic limits based on a flag?
We have flag BLK_FEAT_ATOMIC_WRITES, which could be used, but in
blk_validate_atomic_write_limits() we zero the hw limits if that flag is
unset. So we need to fill in the hw limits like in this patch.
prev parent reply other threads:[~2025-08-21 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 15:02 [RFC PATCH] nvme: add an opt-in to use AWUPF John Garry
2025-08-20 21:51 ` Keith Busch
2025-08-21 5:25 ` Nilay Shroff
2025-08-21 13:42 ` Keith Busch
2025-08-21 8:38 ` Christoph Hellwig
2025-08-21 10:56 ` John Garry
2025-08-21 8:35 ` Christoph Hellwig
2025-08-21 10:33 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14bfcc0e-ec43-4876-9b45-1f2824e1b059@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox