From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
tytso@mit.edu, nilay@linux.ibm.com, martin.petersen@oracle.com,
djwong@kernel.org, mcgrof@infradead.org
Subject: Re: [RFC PATCH] nvme: add an opt-in to use AWUPF
Date: Thu, 21 Aug 2025 10:35:37 +0200 [thread overview]
Message-ID: <20250821083537.GB29224@lst.de> (raw)
In-Reply-To: <20250820150220.1923826-1-john.g.garry@oracle.com>
On Wed, Aug 20, 2025 at 03:02:20PM +0000, John Garry wrote:
> As described at [0], many parts of the atomic write specification are
> lacking.
I like your british understatement.
> + list_for_each_entry(tmp, &subsys->ctrls, subsys_entry)
> + nvme_queue_scan(tmp);
queueing a full rescan here seems expensive. What about just keeping
the awupf value in our internal data structures and always use it
for the physical block size calculation, but only apply it to the
atomic limits based on a flag?
next prev parent reply other threads:[~2025-08-21 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 15:02 [RFC PATCH] nvme: add an opt-in to use AWUPF John Garry
2025-08-20 21:51 ` Keith Busch
2025-08-21 5:25 ` Nilay Shroff
2025-08-21 13:42 ` Keith Busch
2025-08-21 8:38 ` Christoph Hellwig
2025-08-21 10:56 ` John Garry
2025-08-21 8:35 ` Christoph Hellwig [this message]
2025-08-21 10:33 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821083537.GB29224@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox