* [PATCH] nvme-cli: fix wrong bitmask in number of rpmb units.
@ 2017-10-28 18:01 Minwoo Im
2017-10-30 19:36 ` Keith Busch
0 siblings, 1 reply; 2+ messages in thread
From: Minwoo Im @ 2017-10-28 18:01 UTC (permalink / raw)
Number of RPMB Units is a 3-bit field[02:00].
Bitmask should be 0111b(7h) to get this field.
Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
nvme-print.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nvme-print.c b/nvme-print.c
index 9f524cd..e79b3f4 100644
--- a/nvme-print.c
+++ b/nvme-print.c
@@ -218,7 +218,7 @@ static void show_nvme_id_ctrl_rpmbs(__le32 ctrl_rpmbs)
__u32 tsz = (rpmbs & 0xFF0000) >> 16;
__u32 rsvd = (rpmbs & 0xFFC0) >> 6;
__u32 auth = (rpmbs & 0x38) >> 3;
- __u32 rpmb = rpmbs & 0x3;
+ __u32 rpmb = rpmbs & 0x7;
printf(" [31:24]: %#x\tAccess Size\n", asz);
printf(" [23:16]: %#x\tTotal Size\n", tsz);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme-cli: fix wrong bitmask in number of rpmb units.
2017-10-28 18:01 [PATCH] nvme-cli: fix wrong bitmask in number of rpmb units Minwoo Im
@ 2017-10-30 19:36 ` Keith Busch
0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2017-10-30 19:36 UTC (permalink / raw)
On Sun, Oct 29, 2017@03:01:52AM +0900, Minwoo Im wrote:
> Number of RPMB Units is a 3-bit field[02:00].
> Bitmask should be 0111b(7h) to get this field.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-30 19:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-28 18:01 [PATCH] nvme-cli: fix wrong bitmask in number of rpmb units Minwoo Im
2017-10-30 19:36 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox