* [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
@ 2018-02-05 14:24 Sagi Grimberg
2018-02-05 14:28 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sagi Grimberg @ 2018-02-05 14:24 UTC (permalink / raw)
The consumers of this routine expects the affinity map of of vector
index relative to the first completion vector. The upper layers are
not aware of internal/private completion vectors that mlx5 allocates
for its own usage.
Hence, return the affinity map of vector index relative to the first
completion vector.
Fixes: 05e0cc84e00c ("net/mlx5: Fix get vector affinity helper function")
Reported-by: Logan Gunthorpe <logang at deltatee.com>
Tested-by: Max Gurtovoy <maxg at mellanox.com>
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
Cc: <stable at vger.kernel.org> # v4.15
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
include/linux/mlx5/driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
index a0610427e168..b82c4ae92411 100644
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_core_dev *dev, int vector)
int eqn;
int err;
- err = mlx5_vector2eqn(dev, vector, &eqn, &irq);
+ err = mlx5_vector2eqn(dev, MLX5_EQ_VEC_COMP_BASE + vector, &eqn, &irq);
if (err)
return NULL;
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
2018-02-05 14:24 [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0 Sagi Grimberg
@ 2018-02-05 14:28 ` Sagi Grimberg
2018-02-05 15:23 ` Doug Ledford
2018-02-05 15:57 ` Doug Ledford
2018-02-05 17:16 ` Logan Gunthorpe
2 siblings, 1 reply; 6+ messages in thread
From: Sagi Grimberg @ 2018-02-05 14:28 UTC (permalink / raw)
Sorry, now my .gitaliases updated with Jason's correct email.
On 02/05/2018 04:24 PM, Sagi Grimberg wrote:
> The consumers of this routine expects the affinity map of of vector
> index relative to the first completion vector. The upper layers are
> not aware of internal/private completion vectors that mlx5 allocates
> for its own usage.
>
> Hence, return the affinity map of vector index relative to the first
> completion vector.
>
> Fixes: 05e0cc84e00c ("net/mlx5: Fix get vector affinity helper function")
> Reported-by: Logan Gunthorpe <logang at deltatee.com>
> Tested-by: Max Gurtovoy <maxg at mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
> Cc: <stable at vger.kernel.org> # v4.15
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
> include/linux/mlx5/driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
> index a0610427e168..b82c4ae92411 100644
> --- a/include/linux/mlx5/driver.h
> +++ b/include/linux/mlx5/driver.h
> @@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_core_dev *dev, int vector)
> int eqn;
> int err;
>
> - err = mlx5_vector2eqn(dev, vector, &eqn, &irq);
> + err = mlx5_vector2eqn(dev, MLX5_EQ_VEC_COMP_BASE + vector, &eqn, &irq);
> if (err)
> return NULL;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
2018-02-05 14:28 ` Sagi Grimberg
@ 2018-02-05 15:23 ` Doug Ledford
2018-02-05 15:28 ` Sagi Grimberg
0 siblings, 1 reply; 6+ messages in thread
From: Doug Ledford @ 2018-02-05 15:23 UTC (permalink / raw)
On Mon, 2018-02-05@16:28 +0200, Sagi Grimberg wrote:
> Sorry, now my .gitaliases updated with Jason's correct email.
Jason prefers jgg at ziepe.ca for his upstream work, so might need to
update again ;-)
--
Doug Ledford <dledford at redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20180205/b3e1d858/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
2018-02-05 15:23 ` Doug Ledford
@ 2018-02-05 15:28 ` Sagi Grimberg
0 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2018-02-05 15:28 UTC (permalink / raw)
>> Sorry, now my .gitaliases updated with Jason's correct email.
>
> Jason prefers jgg at ziepe.ca for his upstream work, so might need to
> update again ;-)
Updated ;)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
2018-02-05 14:24 [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0 Sagi Grimberg
2018-02-05 14:28 ` Sagi Grimberg
@ 2018-02-05 15:57 ` Doug Ledford
2018-02-05 17:16 ` Logan Gunthorpe
2 siblings, 0 replies; 6+ messages in thread
From: Doug Ledford @ 2018-02-05 15:57 UTC (permalink / raw)
On Mon, 2018-02-05@16:24 +0200, Sagi Grimberg wrote:
> The consumers of this routine expects the affinity map of of vector
> index relative to the first completion vector. The upper layers are
> not aware of internal/private completion vectors that mlx5 allocates
> for its own usage.
>
> Hence, return the affinity map of vector index relative to the first
> completion vector.
>
> Fixes: 05e0cc84e00c ("net/mlx5: Fix get vector affinity helper function")
> Reported-by: Logan Gunthorpe <logang at deltatee.com>
> Tested-by: Max Gurtovoy <maxg at mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
> Cc: <stable at vger.kernel.org> # v4.15
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Thanks, applied.
--
Doug Ledford <dledford at redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20180205/45771bfc/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0
2018-02-05 14:24 [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0 Sagi Grimberg
2018-02-05 14:28 ` Sagi Grimberg
2018-02-05 15:57 ` Doug Ledford
@ 2018-02-05 17:16 ` Logan Gunthorpe
2 siblings, 0 replies; 6+ messages in thread
From: Logan Gunthorpe @ 2018-02-05 17:16 UTC (permalink / raw)
Thanks Sagi,
I can confirm this fixes our issue.
Nice Catch!
Logan
On 05/02/18 07:24 AM, Sagi Grimberg wrote:
> The consumers of this routine expects the affinity map of of vector
> index relative to the first completion vector. The upper layers are
> not aware of internal/private completion vectors that mlx5 allocates
> for its own usage.
>
> Hence, return the affinity map of vector index relative to the first
> completion vector.
>
> Fixes: 05e0cc84e00c ("net/mlx5: Fix get vector affinity helper function")
> Reported-by: Logan Gunthorpe <logang at deltatee.com>
> Tested-by: Max Gurtovoy <maxg at mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
> Cc: <stable at vger.kernel.org> # v4.15
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
> include/linux/mlx5/driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
> index a0610427e168..b82c4ae92411 100644
> --- a/include/linux/mlx5/driver.h
> +++ b/include/linux/mlx5/driver.h
> @@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_core_dev *dev, int vector)
> int eqn;
> int err;
>
> - err = mlx5_vector2eqn(dev, vector, &eqn, &irq);
> + err = mlx5_vector2eqn(dev, MLX5_EQ_VEC_COMP_BASE + vector, &eqn, &irq);
> if (err)
> return NULL;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-05 17:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-05 14:24 [PATCH] mlx5: fix mlx5_get_vector_affinity to start from completion vector 0 Sagi Grimberg
2018-02-05 14:28 ` Sagi Grimberg
2018-02-05 15:23 ` Doug Ledford
2018-02-05 15:28 ` Sagi Grimberg
2018-02-05 15:57 ` Doug Ledford
2018-02-05 17:16 ` Logan Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox