Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: emilne@redhat.com (Ewan D. Milne)
Subject: [PATCH v2] nvmet_fc: support target port removal with nvmet layer
Date: Mon, 13 Aug 2018 12:38:25 -0400	[thread overview]
Message-ID: <1534178305.14774.18.camel@localhost.localdomain> (raw)
In-Reply-To: <2461890d-1bf5-0a7e-0667-d16dbe365f4b@broadcom.com>

On Fri, 2018-08-10@16:21 -0700, James Smart wrote:
> On 8/10/2018 10:53 AM, Ewan D. Milne wrote:
> > You need to add function declarations for nvmet_fc_portentry_unbind_tgt()
> > and nvmet_fc_portentry_rebind_tgt().  [-Werror=implicit-function-declaration]
> >
> > -Ewan
> 
> ??  They are all declared ahead of use
> 
> -- james
> 

They weren't for me, but that's because I applied the patch to my
working tree, rather than nvme-4.19, and the functions ended up
getting placed down further in the file somehow.

-Ewan

  reply	other threads:[~2018-08-13 16:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 23:48 [PATCH v2] nvmet_fc: support target port removal with nvmet layer James Smart
2018-08-10 17:53 ` Ewan D. Milne
2018-08-10 23:21   ` James Smart
2018-08-13 16:38     ` Ewan D. Milne [this message]
2018-08-10 20:50 ` Ewan D. Milne
2018-08-10 23:04   ` James Smart
2018-09-05 19:56 ` Christoph Hellwig
2018-09-05 20:12   ` James Smart
2018-09-11  7:17     ` Christoph Hellwig
2018-09-05 20:24   ` Ewan D. Milne
2018-09-05 20:40     ` James Smart
2018-09-11  7:35 ` Christoph Hellwig
2018-09-11 17:01   ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1534178305.14774.18.camel@localhost.localdomain \
    --to=emilne@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox