* [PATCH] nvme-cli: remove unused NVME_AER_NOTICE_*
@ 2019-05-16 16:41 Akinobu Mita
2019-05-16 16:51 ` Minwoo Im
2019-05-16 23:11 ` Chaitanya Kulkarni
0 siblings, 2 replies; 3+ messages in thread
From: Akinobu Mita @ 2019-05-16 16:41 UTC (permalink / raw)
NVME_AER_NOTICE_* are unused and these values conflict with the values
defined in the kernel nvme.h.
Cc: Keith Busch <keith.busch at intel.com>
Signed-off-by: Akinobu Mita <akinobu.mita at gmail.com>
---
linux/nvme.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/linux/nvme.h b/linux/nvme.h
index cac4d19..13fa52a 100644
--- a/linux/nvme.h
+++ b/linux/nvme.h
@@ -589,9 +589,6 @@ enum {
NVME_AER_SMART = 1,
NVME_AER_CSS = 6,
NVME_AER_VS = 7,
- NVME_AER_NOTICE_NS_CHANGED = 0x0002,
- NVME_AER_NOTICE_ANA = 0x0003,
- NVME_AER_NOTICE_FW_ACT_STARTING = 0x0102,
};
struct nvme_lba_range_type {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme-cli: remove unused NVME_AER_NOTICE_*
2019-05-16 16:41 [PATCH] nvme-cli: remove unused NVME_AER_NOTICE_* Akinobu Mita
@ 2019-05-16 16:51 ` Minwoo Im
2019-05-16 23:11 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Minwoo Im @ 2019-05-16 16:51 UTC (permalink / raw)
> diff --git a/linux/nvme.h b/linux/nvme.h
> index cac4d19..13fa52a 100644
> --- a/linux/nvme.h
> +++ b/linux/nvme.h
> @@ -589,9 +589,6 @@ enum {
> NVME_AER_SMART = 1,
> NVME_AER_CSS = 6,
> NVME_AER_VS = 7,
> - NVME_AER_NOTICE_NS_CHANGED = 0x0002,
> - NVME_AER_NOTICE_ANA = 0x0003,
> - NVME_AER_NOTICE_FW_ACT_STARTING = 0x0102,
> };
It looks like we can sync-up the header files sooner or later from the
kernel code to avoid kind of conflicts you mentioned.
Anyway,
Reviewed-by: Minwoo Im <minwoo.im.dev at gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme-cli: remove unused NVME_AER_NOTICE_*
2019-05-16 16:41 [PATCH] nvme-cli: remove unused NVME_AER_NOTICE_* Akinobu Mita
2019-05-16 16:51 ` Minwoo Im
@ 2019-05-16 23:11 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2019-05-16 23:11 UTC (permalink / raw)
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
On 5/16/19 9:41 AM, Akinobu Mita wrote:
> NVME_AER_NOTICE_* are unused and these values conflict with the values
> defined in the kernel nvme.h.
>
> Cc: Keith Busch <keith.busch at intel.com>
> Signed-off-by: Akinobu Mita <akinobu.mita at gmail.com>
> ---
> linux/nvme.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/linux/nvme.h b/linux/nvme.h
> index cac4d19..13fa52a 100644
> --- a/linux/nvme.h
> +++ b/linux/nvme.h
> @@ -589,9 +589,6 @@ enum {
> NVME_AER_SMART = 1,
> NVME_AER_CSS = 6,
> NVME_AER_VS = 7,
> - NVME_AER_NOTICE_NS_CHANGED = 0x0002,
> - NVME_AER_NOTICE_ANA = 0x0003,
> - NVME_AER_NOTICE_FW_ACT_STARTING = 0x0102,
> };
>
> struct nvme_lba_range_type {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-16 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-16 16:41 [PATCH] nvme-cli: remove unused NVME_AER_NOTICE_* Akinobu Mita
2019-05-16 16:51 ` Minwoo Im
2019-05-16 23:11 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox