From: Paul Webb <paul.x.webb@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Phil Auld <pauld@redhat.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Ramanan Govindarajan <ramanan.govindarajan@oracle.com>,
Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Nicky Veitch <nicky.veitch@oracle.com>
Subject: Re: [External] : Re: [bug-report] 5-9% FIO randomwrite ext4 perf regression on 6.12.y kernel
Date: Fri, 22 Nov 2024 17:18:11 +0000 [thread overview]
Message-ID: <188e08f4-2eb3-41ad-a331-63fd5bb0e7f6@oracle.com> (raw)
In-Reply-To: <20241122121304.GA25877@lst.de>
On 22/11/2024 12:13, Christoph Hellwig wrote:
> On Thu, Nov 21, 2024 at 09:07:32PM +0000, Paul Webb wrote:
>> Christoph:
>> To check for weird lazy init code using write zeroes
>>
>> Values in the 5.15 kernel baseline prior to the commit:
>> $ cat /sys/block/nvme*n1/queue/write_zeroes_max_bytes
>> 0
>> 0
>> 0
>> 0
>>
>> Values in the 6.11 kernel that contains the commit:
>> $ cat /sys/block/nvme*n1/queue/write_zeroes_max_bytes
>> 2199023255040
>> 2199023255040
>> 2199023255040
>> 2199023255040
> Thanks! So 6.11 actually enables write zeroes for your controller.
>
>> Another interesting datapoint is that while performing some runs I am
>> seeing the following output on the console in the 6.11/6.12 kernels that
>> contain the commit:
>>
>> [ 473.398188] operation not supported error, dev nvme2n1, sector 13952 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 0
> .. which it doesn't handle well.
>
>> [ 473.534550] nvme0n1: Dataset Management(0x9) @ LBA 14000, 256 blocks, Invalid Command Opcode (sct 0x0 / sc 0x1) DNR
> .. and interesting this is for a Deallocate, which should only happen
> with the quirk for certain Intel controllers from the very first days of
> nvme.
>
> What controller do you have? Can you post the output of lspci and
> "nvme list"?
Hi Christoph,
The nvme related output from lspci is as follows:
$ lspci | grep -i nvme
19:00.0 Non-Volatile memory controller: Intel Corporation NVMe
Datacenter SSD [3DNAND, Beta Rock Controller]
20:00.0 Non-Volatile memory controller: Intel Corporation NVMe
Datacenter SSD [3DNAND, Beta Rock Controller]
94:00.0 Non-Volatile memory controller: Intel Corporation NVMe
Datacenter SSD [3DNAND, Beta Rock Controller]
9b:00.0 Non-Volatile memory controller: Intel Corporation NVMe
Datacenter SSD [3DNAND, Beta Rock Controller]
$ sudo nvme list
Node Generic SN
Model Namespace
Usage Format FW Rev
--------------------- --------------------- --------------------
---------------------------------------- ----------
-------------------------- ---------------- --------
/dev/nvme0n1 /dev/ng0n1 PHLN942100EQ6P4CGN
7361456_ICRPC2DD2ORA6.4T 0x1 6.40 TB / 6.40
TB 512 B + 0 B VDV1RL06
/dev/nvme1n1 /dev/ng1n1 PHLN942100PE6P4CGN
7361456_ICRPC2DD2ORA6.4T 0x1 6.40 TB / 6.40
TB 512 B + 0 B VDV1RL06
/dev/nvme2n1 /dev/ng2n1 PHLN9415002B6P4CGN
7361456_ICRPC2DD2ORA6.4T 0x1 6.40 TB / 6.40
TB 512 B + 0 B VDV1RL06
/dev/nvme3n1 /dev/ng3n1 PHLN942100DQ6P4CGN
7361456_ICRPC2DD2ORA6.4T 0x1 6.40 TB / 6.40
TB 512 B + 0 B VDV1RL06
next prev parent reply other threads:[~2024-11-22 17:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 21:35 [bug-report] 5-9% FIO randomwrite ext4 perf regression on 6.12.y kernel Saeed Mirzamohammadi
2024-11-21 0:00 ` Chaitanya Kulkarni
2024-11-21 1:20 ` Jens Axboe
2024-11-21 4:57 ` Christoph Hellwig
2024-11-21 14:48 ` Jens Axboe
2024-11-21 11:30 ` Phil Auld
2024-11-21 14:49 ` Jens Axboe
[not found] ` <181bcb70-e0bf-4024-80b7-e79276d6eaf7@oracle.com>
2024-11-21 21:19 ` [External] : " Phil Auld
2024-11-22 12:13 ` Christoph Hellwig
2024-11-22 17:18 ` Paul Webb [this message]
2024-11-22 18:26 ` Saeed Mirzamohammadi
2024-11-22 21:09 ` Keith Busch
2024-11-25 6:46 ` Christoph Hellwig
2024-11-25 18:28 ` Saeed Mirzamohammadi
2024-11-26 4:55 ` Christoph Hellwig
2024-11-26 18:06 ` Saeed Mirzamohammadi
2024-11-26 18:09 ` Christoph Hellwig
2024-11-26 18:13 ` Saeed Mirzamohammadi
2024-11-22 17:13 ` Paul Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188e08f4-2eb3-41ad-a331-63fd5bb0e7f6@oracle.com \
--to=paul.x.webb@oracle.com \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nicky.veitch@oracle.com \
--cc=pauld@redhat.com \
--cc=ramanan.govindarajan@oracle.com \
--cc=saeed.mirzamohammadi@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox