Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Martin George <martinus.gpy@gmail.com>
To: Laurence Oberman <loberman@redhat.com>,
	Guixin Liu <kanie@linux.alibaba.com>,
	 sashiko-reviews@lists.linux.dev
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 3/3] nvme: document the service-time iopolicy sysfs attributes
Date: Mon, 19 Oct 2026 20:16:57 +0530	[thread overview]
Message-ID: <1af1ff8db7803c1b8f8e656eebe249cbe5e622b4.camel@gmail.com> (raw)
In-Reply-To: <1a84584bc9cf64fab6b4e17bdf2050f9b176ad6a.camel@redhat.com>

On Mon, 2026-10-19 at 08:43 -0400, Laurence Oberman wrote:
> On Mon, 2026-10-19 at 17:43 +0530, Martin George wrote:
> > On Mon, 2026-10-19 at 19:13 +0800, Guixin Liu wrote:
> > > > 
> > > > Should "service-time" also be added to the accepted values for
> > > > /sys/class/nvme-subsystem/nvme-subsysX/iopolicy?
> > > > 
> > > > هایی
> > > Sure, changed in v3.
> > 
> > Not just /sys/class/nvme-subsystem/nvme-subsysX/iopolicy, but this
> > should be added to the accepted values in /sys/class/nvme-
> > subsystem/nvme-subsysX/iopolicies as well.
> > 
> > -Martin
> Hello
> 
> There should be no changes needed for my original iopolicies patch 
> 
> iopolicies_show() walks ARRAY_SIZE(nvme_iopolicy_names), so whoever
> adds a service-time policy adds its enum value and its string to
> nvme_iopolicy_names[] as part of that work. The new name then shows
> up
> in iopolicies automatically. The existing iopolicy store path already
> matches against the same array, so both attributes stay in sync
> without
> code changes
> 

I meant adding to the iopolicies documentation here.

-Martin


  parent reply	other threads:[~2026-10-19 14:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  7:56 [PATCH v2 0/3] nvme: introduce the service-time iopolicy Guixin Liu
2026-10-19  7:56 ` [PATCH v2 1/3] nvme-multipath: implement " Guixin Liu
2026-10-19  8:14   ` sashiko-bot
2026-10-19  7:56 ` [PATCH v2 2/3] nvme-multipath: document " Guixin Liu
2026-10-19  7:56 ` [PATCH v2 3/3] nvme: document the service-time iopolicy sysfs attributes Guixin Liu
2026-10-19  8:13   ` sashiko-bot
2026-10-19 11:13     ` Guixin Liu
2026-10-19 12:13       ` Martin George
2026-10-19 12:43         ` Laurence Oberman
2026-10-19 13:21           ` Guixin Liu
2026-10-19 14:46           ` Martin George [this message]
2026-10-19 14:51             ` Laurence Oberman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1af1ff8db7803c1b8f8e656eebe249cbe5e622b4.camel@gmail.com \
    --to=martinus.gpy@gmail.com \
    --cc=kanie@linux.alibaba.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=loberman@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox