Re: [PATCH v2 3/3] nvme: document the service-time iopolicy sysfs attributes

[Guixin Liu <kanie@linux.alibaba.com>]

在 2026/10/19 20:43, Laurence Oberman 写道:
> On Mon, 2026-10-19 at 17:43 +0530, Martin George wrote:
>> On Mon, 2026-10-19 at 19:13 +0800, Guixin Liu wrote:
>>>> Should "service-time" also be added to the accepted values for
>>>> /sys/class/nvme-subsystem/nvme-subsysX/iopolicy?
>>>>
>>>> هایی
>>> Sure, changed in v3.
>> Not just /sys/class/nvme-subsystem/nvme-subsysX/iopolicy, but this
>> should be added to the accepted values in /sys/class/nvme-
>> subsystem/nvme-subsysX/iopolicies as well.
>>
>> -Martin
> Hello
>
> There should be no changes needed for my original iopolicies patch 
>
> iopolicies_show() walks ARRAY_SIZE(nvme_iopolicy_names), so whoever
> adds a service-time policy adds its enum value and its string to
> nvme_iopolicy_names[] as part of that work. The new name then shows up
> in iopolicies automatically. The existing iopolicy store path already
> matches against the same array, so both attributes stay in sync without
> code changes
Yes, it is.

Best Regards,
Guixin Liu
>
> Thanks
> Laurence