From: hch@infradead.org (Christoph Hellwig)
Subject: nvme lightnvm comments
Date: Mon, 23 Nov 2015 11:53:06 -0800 [thread overview]
Message-ID: <20151123195306.GA18448@infradead.org> (raw)
In-Reply-To: <20151123160319.GA7208@localhost.localdomain>
On Mon, Nov 23, 2015@04:03:20PM +0000, Keith Busch wrote:
> We also thought it'd have been cleaner to have a different command set,
> but the committee hasn't taken on assigning these reserved bits for any
> new purposes yet. LightNVM detection is done with the vendor + device
> id at the moment.
I saw the vendor + device, but even with that I'd rather see a reserved
value in the command set in addition. Claiming that we're NVM if we're
not is a bad idea.
While we're at it - the NVMe driver really should check for these
reserved bits and reject a PCIe device that doesn't claim to implement
the NVM command set.
next prev parent reply other threads:[~2015-11-23 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 10:50 nvme lightnvm comments Christoph Hellwig
2015-11-20 11:06 ` Matias Bjørling
2015-11-20 16:47 ` Christoph Hellwig
2015-11-20 21:26 ` Matias Bjørling
2015-11-21 8:19 ` Christoph Hellwig
2015-11-21 11:12 ` Christoph Hellwig
2015-11-22 18:17 ` Matias Bjørling
2015-11-23 15:45 ` Christoph Hellwig
2015-11-23 16:03 ` Keith Busch
2015-11-23 19:53 ` Christoph Hellwig [this message]
2015-11-23 20:09 ` Matias Bjørling
2015-11-23 19:01 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123195306.GA18448@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox