From: m@bjorling.me (Matias Bjørling)
Subject: nvme lightnvm comments
Date: Fri, 20 Nov 2015 22:26:27 +0100 [thread overview]
Message-ID: <564F9003.5080109@bjorling.me> (raw)
In-Reply-To: <20151120164709.GA9931@infradead.org>
On 11/20/2015 05:47 PM, Christoph Hellwig wrote:
> On Fri, Nov 20, 2015@12:06:36PM +0100, Matias Bj?rling wrote:
>>> 2) please build the lightnvm.o object conditionally in the makefile
>>
>> Then the functions
>>
>> nvme_nvm_register
>> nvme_nvm_unregister
>> nvme_nvm_register
>>
>> have to be #ifdef'ed in the pci file. Do you want that instead? It was on
>> purpose the other way around, so that the nvme_nvm_* functions was null
>> functions if lightnvm isn't compiled in.
>
> Just keep the stubs as inlines in the header.
>
That'll do.
Do you have any plans for exposing the completion_entry on
req_completion in the driver? I'm interested in the fields ->result and
->rsvd in struct nvme_completion. They contain the completion bits for
each of the PPA entries. Which I'll need higher up in the stack to
perform correct retries and so forth.
next prev parent reply other threads:[~2015-11-20 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 10:50 nvme lightnvm comments Christoph Hellwig
2015-11-20 11:06 ` Matias Bjørling
2015-11-20 16:47 ` Christoph Hellwig
2015-11-20 21:26 ` Matias Bjørling [this message]
2015-11-21 8:19 ` Christoph Hellwig
2015-11-21 11:12 ` Christoph Hellwig
2015-11-22 18:17 ` Matias Bjørling
2015-11-23 15:45 ` Christoph Hellwig
2015-11-23 16:03 ` Keith Busch
2015-11-23 19:53 ` Christoph Hellwig
2015-11-23 20:09 ` Matias Bjørling
2015-11-23 19:01 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F9003.5080109@bjorling.me \
--to=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox