From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Split shutdown work
Date: Mon, 23 Nov 2015 23:34:48 -0800 [thread overview]
Message-ID: <20151124073448.GA17979@infradead.org> (raw)
In-Reply-To: <1448302665-9703-1-git-send-email-keith.busch@intel.com>
On Mon, Nov 23, 2015@11:17:45AM -0700, Keith Busch wrote:
> Setting the queue count has a special check for a disabled device in
> order to set an appropriate return code as this command may legitimately
> fail.
Btw, I've tried to understand this as the explanation didn't make sense
to me. I think I finally found the culprit, and it's this text:
"This feature shall only be issued during initialization prior to creation
of any I/O Submission and/or Completion Queues. The value allocated shall
not change between resets."
To be this doesn't indicated that it can legitimately fail. but rather
that we must not even submit it during a reset or resume. One more
reason for a proper state model..
next prev parent reply other threads:[~2015-11-24 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 18:17 [PATCH] NVMe: Split shutdown work Keith Busch
2015-11-24 7:34 ` Christoph Hellwig [this message]
2015-11-24 15:14 ` Keith Busch
2015-11-24 15:31 ` Christoph Hellwig
2015-11-24 16:13 ` Keith Busch
2015-11-24 17:58 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-11-23 19:59 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124073448.GA17979@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox