Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sujith_pandel@dell.com (Sujith Pandel)
Subject: [PATCH for-4.4] NVMe: IO ending fixes on surprise removal
Date: Fri, 18 Dec 2015 00:19:42 -0500	[thread overview]
Message-ID: <20151218051936.GA9107@localhost.localdomain> (raw)
In-Reply-To: <1449864868-8216-1-git-send-email-keith.busch@intel.com>

On Fri, Dec 11, 2015@02:14:28PM -0600, Keith Busch wrote:
> This patch fixes a lost request discovered during IO + hot removal.
> 
> The driver's pci removal deletes gendisks prior to shutting down the
> controller to allow dirty data to sync. Dirty data can not be synced on
> a surprise removal, though, and would potentially block indefinitely.
> 
> The driver previously had marked the queue as dying in this scenario
> to prevent new requests from attempting, however it will still block
> for requests that already entered the queue. This patch fixes this by
> quiescing IO first, then aborting the requeued requests before deleting
> disks.
> 
> Reported-by: Sujith Pandel <sujith_pandel at dell.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Tested this patch against linux-4.4-rc4.
I/O terminated successfully everytime and hotplug-removal is clean i.e
no remnants of the removed NVMe disk is present.

Tested-by: Sujith Pandel <sujith_pandel at dell.com>

Thanks and Regards,
Sujith

      parent reply	other threads:[~2015-12-18  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 20:14 [PATCH for-4.4] NVMe: IO ending fixes on surprise removal Keith Busch
2015-12-13 14:59 ` Sagi Grimberg
2015-12-14 16:29   ` Keith Busch
2015-12-15 15:45     ` Sagi Grimberg
2015-12-18  5:19 ` Sujith Pandel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151218051936.GA9107@localhost.localdomain \
    --to=sujith_pandel@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox