From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCH for-4.4] NVMe: IO ending fixes on surprise removal
Date: Sun, 13 Dec 2015 16:59:52 +0200 [thread overview]
Message-ID: <566D87E8.3000305@dev.mellanox.co.il> (raw)
In-Reply-To: <1449864868-8216-1-git-send-email-keith.busch@intel.com>
> - if (kill)
> + if (kill) {
> blk_set_queue_dying(ns->queue);
> +
> + /*
> + * The controller was shutdown first if we got here through
> + * device removal. The shutdown may requeue outstanding
> + * requests. These need to be aborted immediately so
> + * del_gendisk doesn't block indefinitely for their completion.
> + */
> + blk_mq_abort_requeue_list(ns->queue);
Something looks convoluted a bit here.
We abort_requeue_list here and...
> + }
> if (ns->disk->flags & GENHD_FL_UP)
> del_gendisk(ns->disk);
> if (kill || !blk_queue_dying(ns->queue)) {
Here again?
next prev parent reply other threads:[~2015-12-13 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 20:14 [PATCH for-4.4] NVMe: IO ending fixes on surprise removal Keith Busch
2015-12-13 14:59 ` Sagi Grimberg [this message]
2015-12-14 16:29 ` Keith Busch
2015-12-15 15:45 ` Sagi Grimberg
2015-12-18 5:19 ` Sujith Pandel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566D87E8.3000305@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox