Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Create discard zero quirk white list
Date: Fri, 4 Mar 2016 10:04:43 -0800	[thread overview]
Message-ID: <20160304180443.GA3972@infradead.org> (raw)
In-Reply-To: <1457113522-14099-1-git-send-email-keith.busch@intel.com>

On Fri, Mar 04, 2016@10:45:22AM -0700, Keith Busch wrote:
> The NVMe specification does not require discarded blocks return zeroes on
> read, but provides that behavior as a possibility. Some applications more
> efficiently use an SSD if reads on discarded blocks were deterministically
> zero, based on the "discard_zeroes_data" queue attribute.

Meh, indeed:

"If a read occurs to a deallocated range, the controller shall return
all zeros, all ones, or the last data written to the associated LBA."

time to write a TP for a bit on the identify page..

> There is no specification defined way to determine device behavior on
> discarded blocks, so the driver always left the queue setting disabled. We
> can only know behavior based on individual device models, so this patch
> adds a flag to the NVMe "quirk" list that vendors may set if they know
> their controller works that way. The patch also sets the new flag for one
> such known device.
> 
> Suggested-by: Artur Paszkiewicz <artur.paszkiewicz at intel.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Not happy about this, but I guess we'll need something like this in the
long run..

Reviewed-by: Christoph Hellwig <hch at lst.de>

  reply	other threads:[~2016-03-04 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 17:45 [PATCH] NVMe: Create discard zero quirk white list Keith Busch
2016-03-04 18:04 ` Christoph Hellwig [this message]
2016-03-04 18:13   ` Keith Busch
2016-03-05 22:39   ` Matthew Wilcox
2016-03-06  6:20     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160304180443.GA3972@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox