Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Re-introduce polling for completions
Date: Tue, 5 Apr 2016 22:29:54 +0000	[thread overview]
Message-ID: <20160405222953.GE12625@localhost.localdomain> (raw)
In-Reply-To: <36E8D38D6B771A4BBDB1C0D800158A51865F402E@SSIEXCH-MB3.ssi.samsung.com>

On Tue, Apr 05, 2016@10:04:22PM +0000, Judy Brock-SSI wrote:
> Going straight to MSI-x is a higher risk change since re-introducing polling restores code that was in place previously with no reported problems whereas changing the init path to something new has no test time on it.

Well, I wouldn't say "no" test time since we have a well tested path
that goes straight to MSI-x in place for some time.

If we rely on polled completions during initialization, we potentially
add up to 2 seconds for device initialization to complete (1 second
polling interval * 2 commands using broken IRQ).

Maybe you want both?

  reply	other threads:[~2016-04-05 22:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 22:24 [PATCH] NVMe: Re-introduce polling for completions Keith Busch
2016-04-05  7:32 ` Johannes Thumshirn
2016-04-05 12:35 ` Christoph Hellwig
2016-04-05 17:54   ` Keith Busch
2016-04-05 21:39     ` Keith Busch
2016-04-05 22:04       ` Judy Brock-SSI
2016-04-05 22:29         ` Keith Busch [this message]
2016-04-06  5:22           ` Judy Brock-SSI
2016-04-06  6:56         ` Christoph Hellwig
2016-04-06  6:56       ` Christoph Hellwig
2016-04-12 19:00       ` Christoph Hellwig
2016-04-12 19:02         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405222953.GE12625@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox