From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Re-introduce polling for completions
Date: Tue, 5 Apr 2016 23:56:04 -0700 [thread overview]
Message-ID: <20160406065604.GA9391@infradead.org> (raw)
In-Reply-To: <20160405213904.GD12625@localhost.localdomain>
On Tue, Apr 05, 2016@09:39:04PM +0000, Keith Busch wrote:
> Before I resend with the requested code comments, I'd like to hear your
> opinion on an alternate solution (patch below).
>
> Currently the driver uses legacy IRQ if available only until we know how
> many queues it can create. The legacy IRQ use is tripping up some h/w,
> but I've not heard such issues with MSI/MSI-x.
>
> Would you prefer going straight to MSI-x? The driver does that when
> there is no INTx, but we wouldn't need to poll from the watchdog timer
> if we make MSI-x the default behavior,
I would much prefer that variant over doing crazy non-standard polling.
next prev parent reply other threads:[~2016-04-06 6:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 22:24 [PATCH] NVMe: Re-introduce polling for completions Keith Busch
2016-04-05 7:32 ` Johannes Thumshirn
2016-04-05 12:35 ` Christoph Hellwig
2016-04-05 17:54 ` Keith Busch
2016-04-05 21:39 ` Keith Busch
2016-04-05 22:04 ` Judy Brock-SSI
2016-04-05 22:29 ` Keith Busch
2016-04-06 5:22 ` Judy Brock-SSI
2016-04-06 6:56 ` Christoph Hellwig
2016-04-06 6:56 ` Christoph Hellwig [this message]
2016-04-12 19:00 ` Christoph Hellwig
2016-04-12 19:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406065604.GA9391@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox