RFC: what to do about abort?

[hch@infradead.org (Christoph Hellwig)]

On Wed, May 04, 2016@02:59:11PM +0000, Busch, Keith wrote:
> That's an unfortunate way to the spec describes this command. All my
> controllers immediately post success status with the CQE's DWORD0 set
> to 0;abort is essentially a no-op.

That's one of the most common behaviors instead.

> Even though it's a no-op for me, the main benefit is that abort makes
> for an awesome trigger for analyzers and firmware. It's been a valuable
> tool for debugging issues, and I'd hate to lose it.

You're the maintainer, so it's up to you - it just doesn't seem very
useful to me from both the host and device perspectice.

> Can we propose changing the spec instead?

Good luck changing existing NVMe behavior.  We could probably introduce
an optional well defined abort, but I'm not sure lots of vendors would
even bother to implement it unless there is a hard requirement for it.