Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: RFC: what to do about abort?
Date: Sun, 8 May 2016 02:04:06 -0700	[thread overview]
Message-ID: <20160508090406.GA27077@infradead.org> (raw)
In-Reply-To: <20160505215633.GF8503@localhost.localdomain>

On Thu, May 05, 2016@05:56:33PM -0400, Keith Busch wrote:
> If you don't find a deterministic event on failure to be useful for the
> device side, you must have better visibility into your internal device
> state than most others do. :)

I get a deterministic error: the controller reset.

> The spec so badly defines abort, though, I have to agree you're right
> to remove it. Since having a dependable event greatly helps debugging
> field issues when device makers desperately want to blame the driver
> for command timeouts, does it sound okay to have a module param toggle
> its use, defaulting to off?

Let's just keep it.  I don't think it's helpful, but it's not that bad
that we have to get rid of it.

      reply	other threads:[~2016-05-08  9:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 10:03 RFC: what to do about abort? Christoph Hellwig
2016-05-04 10:19 ` Hannes Reinecke
2016-05-04 10:58   ` Christoph Hellwig
2016-05-04 14:59     ` Busch, Keith
2016-05-05 14:11       ` Christoph Hellwig
2016-05-05 21:56         ` Keith Busch
2016-05-08  9:04           ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160508090406.GA27077@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox