Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Fix possible scheduling while atomic error
Date: Wed, 25 May 2016 01:18:42 -0700	[thread overview]
Message-ID: <20160525081842.GA22766@infradead.org> (raw)
In-Reply-To: <20160524195921.GB24347@localhost.localdomain>

On Tue, May 24, 2016@03:59:21PM -0400, Keith Busch wrote:
> On Tue, May 24, 2016@11:43:21AM -0700, Ming Lin wrote:
> > 
> > It's blk_mq_cancel_requeue_work() that potentially sleeps.
> 
> Right, I don't know what I was thinking... 
> 
> AFAICT, the patch is fine as-is if Christoph is okay with it.

I still don't why we need to delay the call to blk_mq_stop_hw_queues
to ->queue_rq.

  reply	other threads:[~2016-05-25  8:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 21:37 [PATCH] NVMe: Fix possible scheduling while atomic error Keith Busch
2016-05-23 10:58 ` Christoph Hellwig
2016-05-23 13:41   ` Keith Busch
2016-05-23 14:36     ` Christoph Hellwig
2016-05-23 14:55       ` Keith Busch
2016-05-24 18:43         ` Ming Lin
2016-05-24 19:59           ` Keith Busch
2016-05-25  8:18             ` Christoph Hellwig [this message]
2016-05-25 17:57               ` Keith Busch
2016-05-27  7:40                 ` Christoph Hellwig
2016-06-08 11:17                   ` Sagi Grimberg
2016-06-08 14:43                     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160525081842.GA22766@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox