* [PATCH] nvme/pci: Don't mark IOD as aborted if abort wasn't sent
@ 2017-01-24 23:07 Keith Busch
2017-01-25 8:14 ` Christoph Hellwig
2017-01-31 15:35 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Keith Busch @ 2017-01-24 23:07 UTC (permalink / raw)
This patch sets the aborted flag only if an abort was sent, reducing
excessive kernel message spamming for completed IO that wasn't actually
aborted.
Reported-by: Jens Axboe <axboe at kernel.dk>
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 3d21a15..f88659b 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -905,12 +905,11 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
return BLK_EH_HANDLED;
}
- iod->aborted = 1;
-
if (atomic_dec_return(&dev->ctrl.abort_limit) < 0) {
atomic_inc(&dev->ctrl.abort_limit);
return BLK_EH_RESET_TIMER;
}
+ iod->aborted = 1;
memset(&cmd, 0, sizeof(cmd));
cmd.abort.opcode = nvme_admin_abort_cmd;
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] nvme/pci: Don't mark IOD as aborted if abort wasn't sent
2017-01-24 23:07 [PATCH] nvme/pci: Don't mark IOD as aborted if abort wasn't sent Keith Busch
@ 2017-01-25 8:14 ` Christoph Hellwig
2017-01-31 11:25 ` Sagi Grimberg
2017-01-31 15:35 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2017-01-25 8:14 UTC (permalink / raw)
On Tue, Jan 24, 2017@06:07:00PM -0500, Keith Busch wrote:
> This patch sets the aborted flag only if an abort was sent, reducing
> excessive kernel message spamming for completed IO that wasn't actually
> aborted.
>
> Reported-by: Jens Axboe <axboe at kernel.dk>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme/pci: Don't mark IOD as aborted if abort wasn't sent
2017-01-25 8:14 ` Christoph Hellwig
@ 2017-01-31 11:25 ` Sagi Grimberg
0 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2017-01-31 11:25 UTC (permalink / raw)
Looks good,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme/pci: Don't mark IOD as aborted if abort wasn't sent
2017-01-24 23:07 [PATCH] nvme/pci: Don't mark IOD as aborted if abort wasn't sent Keith Busch
2017-01-25 8:14 ` Christoph Hellwig
@ 2017-01-31 15:35 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-01-31 15:35 UTC (permalink / raw)
On 01/24/2017 03:07 PM, Keith Busch wrote:
> This patch sets the aborted flag only if an abort was sent, reducing
> excessive kernel message spamming for completed IO that wasn't actually
> aborted.
Thanks for handling this Keith, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-31 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-24 23:07 [PATCH] nvme/pci: Don't mark IOD as aborted if abort wasn't sent Keith Busch
2017-01-25 8:14 ` Christoph Hellwig
2017-01-31 11:25 ` Sagi Grimberg
2017-01-31 15:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox