From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet: Do not check for sg_cnt being zero for read/write commands.
Date: Wed, 8 Feb 2017 09:24:26 +0100 [thread overview]
Message-ID: <20170208082426.GA7629@lst.de> (raw)
In-Reply-To: <1486510557-26831-1-git-send-email-parav@mellanox.com>
On Tue, Feb 07, 2017@05:35:57PM -0600, Parav Pandit wrote:
> sg_cnt cannot be zero for inline or sge mode from the fabric drivers
> because nvme read/write commands have minimum of one block to be
> read or written. (nlb dw12 is 0 based value).
> So sg_cnt check for 0 is not useful.
Except that we currently don't verify the data transfer in the SGL
matches that in the command. It's been on my todo list for a while,
so maybe you can take it off my plate first before we'll aply this
patch.
next prev parent reply other threads:[~2017-02-08 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 23:35 [PATCH] nvmet: Do not check for sg_cnt being zero for read/write commands Parav Pandit
2017-02-08 8:24 ` Christoph Hellwig [this message]
2017-02-08 9:43 ` Sagi Grimberg
2017-02-08 11:54 ` Christoph Hellwig
2017-02-08 15:11 ` Parav Pandit
2017-02-08 20:06 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208082426.GA7629@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox