From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet: Do not check for sg_cnt being zero for read/write commands.
Date: Wed, 8 Feb 2017 12:54:30 +0100 [thread overview]
Message-ID: <20170208115430.GA11342@lst.de> (raw)
In-Reply-To: <eb2c9d8b-ead6-8472-1f3a-9f91ca5cb0de@grimberg.me>
On Wed, Feb 08, 2017@11:43:23AM +0200, Sagi Grimberg wrote:
>
>> Except that we currently don't verify the data transfer in the SGL
>> matches that in the command. It's been on my todo list for a while,
>> so maybe you can take it off my plate first before we'll aply this
>> patch.
>
> Any reason not to take it as is and add the sgl validity check
> incrementally?
Because that would allow a bad actor host to crash the target easily.
next prev parent reply other threads:[~2017-02-08 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 23:35 [PATCH] nvmet: Do not check for sg_cnt being zero for read/write commands Parav Pandit
2017-02-08 8:24 ` Christoph Hellwig
2017-02-08 9:43 ` Sagi Grimberg
2017-02-08 11:54 ` Christoph Hellwig [this message]
2017-02-08 15:11 ` Parav Pandit
2017-02-08 20:06 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208115430.GA11342@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox