From: keith.busch@intel.com (Keith Busch)
Subject: nvme defintions not used in the kernel
Date: Thu, 29 Jun 2017 11:37:50 -0400 [thread overview]
Message-ID: <20170629153749.GD3110@localhost.localdomain> (raw)
In-Reply-To: <20170628231129.GA20902@lst.de>
On Thu, Jun 29, 2017@01:11:29AM +0200, Christoph Hellwig wrote:
> Hi all,
>
> currently nvme-cli supports various nvme features that are not
> needed in the kernel and keeps them in its own nvme.h file,
> in addition to pulling in the kernel one.
>
> Do we want to keep it that way in the long run, or just add
> things to nvme.h in the kernel even if they are not used to
> keep things in a single place.
>
> To me the latter would seem a little nicer, especially as it
> doesn't involve a whole lot of defintion.
Hm, the only thing nvme-cli should be copying from Linux is the headers
defining ioctls and their arguments. The specification defined structures
and commands should be OS agnostic in the tooling, so personally I think
it's less work to let them evolve independently.
That said, it's a nice goal to keep them in sync if someone wants to
put the effort into that.
prev parent reply other threads:[~2017-06-29 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 23:11 nvme defintions not used in the kernel Christoph Hellwig
2017-06-28 23:13 ` Jens Axboe
2017-06-29 5:44 ` Sagi Grimberg
2017-06-29 8:32 ` Johannes Thumshirn
2017-06-29 13:31 ` Christoph Hellwig
2017-06-29 14:25 ` Sagi Grimberg
2017-06-29 15:37 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629153749.GD3110@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox