From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/2] nvme: Provide option to disable ASPT feature
Date: Thu, 27 Jul 2017 14:09:38 -0400 [thread overview]
Message-ID: <20170727180938.GK11979@localhost.localdomain> (raw)
In-Reply-To: <5DFAE162-66C5-4860-8330-8B5F34517E60@amacapital.net>
On Thu, Jul 27, 2017@01:28:20PM -0400, Andy Lutomirski wrote:
>
>
> > On Jul 27, 2017,@12:58 PM, Keith Busch <keith.busch@intel.com> wrote:
> >
> > Similar to PCIe's APSM, the NVMe driver needs the ability to not use APST
> > feature so that users have a way to prevent this feature from making their
> > machines unusable. This patch makes that possible via module parameter
> > "apst_off".
>
> Isn't this redundant with default_ps_max_latency=0?
Ah, thanks, so it is. I thought this wasn't considered through
nvme_init_identify, but ctrl->ps_max_latency_us would be 0.
This patch isn't needed, but we still need patch 1 in this series.
next prev parent reply other threads:[~2017-07-27 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 16:58 [PATCH 1/2] nvme: Fix nvme reset command timeout handling Keith Busch
2017-07-27 16:58 ` [PATCH 2/2] nvme: Provide option to disable ASPT feature Keith Busch
2017-07-27 17:28 ` Andy Lutomirski
2017-07-27 18:09 ` Keith Busch [this message]
2017-07-28 7:58 ` [PATCH 1/2] nvme: Fix nvme reset command timeout handling Johannes Thumshirn
2017-08-10 8:38 ` Christoph Hellwig
2017-08-10 8:48 ` Johannes Thumshirn
2017-08-10 8:57 ` Christoph Hellwig
2017-08-10 9:05 ` Johannes Thumshirn
2017-08-10 16:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727180938.GK11979@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox