From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: Fix nvme reset command timeout handling
Date: Thu, 10 Aug 2017 10:38:27 +0200 [thread overview]
Message-ID: <20170810083827.GB22739@lst.de> (raw)
In-Reply-To: <20170728075834.GC4043@linux-x5ow.site>
On Fri, Jul 28, 2017@09:58:34AM +0200, Johannes Thumshirn wrote:
> On Thu, Jul 27, 2017@12:58:40PM -0400, Keith Busch wrote:
> > static void nvme_set_latency_tolerance(struct device *dev, s32 val)
> > @@ -1856,17 +1857,25 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)
> >
> > kfree(id);
> >
> > + if (ret < 0)
> > + return ret;
> > +
>
> This is a bit confusing IMHO, how about this?
Agreed.
We probably should get this series into 4.13, so other comments would
be welcome.
next prev parent reply other threads:[~2017-08-10 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 16:58 [PATCH 1/2] nvme: Fix nvme reset command timeout handling Keith Busch
2017-07-27 16:58 ` [PATCH 2/2] nvme: Provide option to disable ASPT feature Keith Busch
2017-07-27 17:28 ` Andy Lutomirski
2017-07-27 18:09 ` Keith Busch
2017-07-28 7:58 ` [PATCH 1/2] nvme: Fix nvme reset command timeout handling Johannes Thumshirn
2017-08-10 8:38 ` Christoph Hellwig [this message]
2017-08-10 8:48 ` Johannes Thumshirn
2017-08-10 8:57 ` Christoph Hellwig
2017-08-10 9:05 ` Johannes Thumshirn
2017-08-10 16:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810083827.GB22739@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox