From: keith.busch@intel.com (Keith Busch)
Subject: Bug Report: can't unload nvme module in case of disabled device
Date: Mon, 14 Aug 2017 16:24:15 -0400 [thread overview]
Message-ID: <20170814202414.GH7233@localhost.localdomain> (raw)
In-Reply-To: <b4c07a4b-de93-ef0c-d3d4-79baaa01d0c6@mellanox.com>
On Sun, Aug 13, 2017@11:29:59AM +0300, Max Gurtovoy wrote:
>
> After bisecting I found that the following commit caused the simple
> load/unload nvme driver failure:
>
> commit 1ad43c0078b79a76accd0fe64062e47b3430dc6b
> Author: Ming Lei <minlei at redhat.com>
> Date: Wed Aug 2 08:01:45 2017 +0800
>
> blk-mq: don't leak preempt counter/q_usage_counter when allocating rq
> failed
>
> Adding Ming to this thread.
>
> I'm continuing with the debug of the new scenario (load nvme && sleep 10 &&
> unload nvme).
I'm reviewing that commit, and it looks wrong to me. It is only pairing
the blk_queue_exit if request allocation was successful. That will get
the q_usage_counter off when request allocation fails, making a queue
freeze impossible. I'll send a patch.
next prev parent reply other threads:[~2017-08-14 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 12:58 Bug Report: can't unload nvme module in case of disabled device Max Gurtovoy
2017-08-10 8:59 ` Christoph Hellwig
2017-08-10 17:04 ` Max Gurtovoy
2017-08-10 19:36 ` Keith Busch
2017-08-13 8:29 ` Max Gurtovoy
2017-08-14 20:24 ` Keith Busch [this message]
2017-08-10 16:45 ` Keith Busch
2017-08-10 19:17 ` Keith Busch
2017-08-10 19:34 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814202414.GH7233@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox