* nvme-4.14 rebased
@ 2017-08-16 8:13 Christoph Hellwig
2017-08-11 11:08 ` Jon Derrick
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-08-16 8:13 UTC (permalink / raw)
Hi all,
I've rebased the nvme-4.14 branch on top of the nvme-4.13 branch
to avoid conflicts. As part of that I made the timestamp set features
return an error similar to the other reset fixes.
Jon: can you double check the change is correct?
^ permalink raw reply [flat|nested] 3+ messages in thread
* nvme-4.14 rebased
2017-08-16 8:13 nvme-4.14 rebased Christoph Hellwig
@ 2017-08-11 11:08 ` Jon Derrick
2017-08-16 16:07 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: Jon Derrick @ 2017-08-11 11:08 UTC (permalink / raw)
On 08/16/2017 02:13 AM, Christoph Hellwig wrote:
> Hi all,
>
> I've rebased the nvme-4.14 branch on top of the nvme-4.13 branch
> to avoid conflicts. As part of that I made the timestamp set features
> return an error similar to the other reset fixes.
>
> Jon: can you double check the change is correct?
>
Hi Christoph,
The only thing I'd suggest is not letting a failure to set the timestamp
be a failure to initialize the controller.
Regards,
Jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* nvme-4.14 rebased
2017-08-11 11:08 ` Jon Derrick
@ 2017-08-16 16:07 ` Keith Busch
0 siblings, 0 replies; 3+ messages in thread
From: Keith Busch @ 2017-08-16 16:07 UTC (permalink / raw)
On Fri, Aug 11, 2017@05:08:37AM -0600, Jon Derrick wrote:
> On 08/16/2017 02:13 AM, Christoph Hellwig wrote:
> > Hi all,
> >
> > I've rebased the nvme-4.14 branch on top of the nvme-4.13 branch
> > to avoid conflicts. As part of that I made the timestamp set features
> > return an error similar to the other reset fixes.
> >
> > Jon: can you double check the change is correct?
> >
>
> Hi Christoph,
>
> The only thing I'd suggest is not letting a failure to set the timestamp
> be a failure to initialize the controller.
It looks like Christoph just has it fail initialization if the timestamp
feature command never gets a controller response. We actually do need
to abandon controller init in that case since the controller is disabled
in the timeout handler.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-16 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16 8:13 nvme-4.14 rebased Christoph Hellwig
2017-08-11 11:08 ` Jon Derrick
2017-08-16 16:07 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox