* [PATCH] nvme/host: generate spec-compliant UUID NQNs
@ 2017-08-30 22:18 Daniel Verkamp
2017-08-31 9:14 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Verkamp @ 2017-08-30 22:18 UTC (permalink / raw)
The default host NQN, which is generated based on the host's UUID,
does not follow the UUID-based NQN format laid out in the NVMe 1.3
specification. Remove the "NVMf:" portion of the NQN to match the spec.
Signed-off-by: Daniel Verkamp <daniel.verkamp at intel.com>
---
drivers/nvme/host/fabrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 5f5cd306f76d..ffa7191ddfa5 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -75,7 +75,7 @@ static struct nvmf_host *nvmf_host_default(void)
kref_init(&host->ref);
snprintf(host->nqn, NVMF_NQN_SIZE,
- "nqn.2014-08.org.nvmexpress:NVMf:uuid:%pUb", &host->id);
+ "nqn.2014-08.org.nvmexpress:uuid:%pUb", &host->id);
mutex_lock(&nvmf_hosts_mutex);
list_add_tail(&host->list, &nvmf_hosts);
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] nvme/host: generate spec-compliant UUID NQNs
2017-08-30 22:18 [PATCH] nvme/host: generate spec-compliant UUID NQNs Daniel Verkamp
@ 2017-08-31 9:14 ` Christoph Hellwig
2017-08-31 9:22 ` Max Gurtovoy
2017-09-03 17:45 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-08-31 9:14 UTC (permalink / raw)
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme/host: generate spec-compliant UUID NQNs
2017-08-30 22:18 [PATCH] nvme/host: generate spec-compliant UUID NQNs Daniel Verkamp
2017-08-31 9:14 ` Christoph Hellwig
@ 2017-08-31 9:22 ` Max Gurtovoy
2017-09-03 17:45 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Max Gurtovoy @ 2017-08-31 9:22 UTC (permalink / raw)
On 8/31/2017 1:18 AM, Daniel Verkamp wrote:
> The default host NQN, which is generated based on the host's UUID,
> does not follow the UUID-based NQN format laid out in the NVMe 1.3
> specification. Remove the "NVMf:" portion of the NQN to match the spec.
>
> Signed-off-by: Daniel Verkamp <daniel.verkamp at intel.com>
> ---
> drivers/nvme/host/fabrics.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index 5f5cd306f76d..ffa7191ddfa5 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
Looks good,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme/host: generate spec-compliant UUID NQNs
2017-08-30 22:18 [PATCH] nvme/host: generate spec-compliant UUID NQNs Daniel Verkamp
2017-08-31 9:14 ` Christoph Hellwig
2017-08-31 9:22 ` Max Gurtovoy
@ 2017-09-03 17:45 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2017-09-03 17:45 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-03 17:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-30 22:18 [PATCH] nvme/host: generate spec-compliant UUID NQNs Daniel Verkamp
2017-08-31 9:14 ` Christoph Hellwig
2017-08-31 9:22 ` Max Gurtovoy
2017-09-03 17:45 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox